pmdomain: starfive: Remove redundant dev_err()

[PATCH] pmdomain: starfive: Remove redundant dev_err()

Posted by Pan Chuang 1 week, 2 days ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/pmdomain/starfive/jh71xx-pmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pmdomain/starfive/jh71xx-pmu.c b/drivers/pmdomain/starfive/jh71xx-pmu.c
index 74720c09a6e3..aff07b0f5523 100644
--- a/drivers/pmdomain/starfive/jh71xx-pmu.c
+++ b/drivers/pmdomain/starfive/jh71xx-pmu.c
@@ -276,8 +276,6 @@ static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu
 
 	ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
 			       0, pdev->name, pmu);
-	if (ret)
-		dev_err(dev, "failed to request irq\n");
 
 	jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
 
-- 
2.34.1

Re: [PATCH] pmdomain: starfive: Remove redundant dev_err()

Posted by Ulf Hansson 1 week, 2 days ago

On Thu, Jul 16, 2026 at 11:23 AM Pan Chuang <panchuang@vivo.com> wrote:
>
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/starfive/jh71xx-pmu.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pmdomain/starfive/jh71xx-pmu.c b/drivers/pmdomain/starfive/jh71xx-pmu.c
> index 74720c09a6e3..aff07b0f5523 100644
> --- a/drivers/pmdomain/starfive/jh71xx-pmu.c
> +++ b/drivers/pmdomain/starfive/jh71xx-pmu.c
> @@ -276,8 +276,6 @@ static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu
>
>         ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
>                                0, pdev->name, pmu);
> -       if (ret)
> -               dev_err(dev, "failed to request irq\n");
>
>         jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
>
> --
> 2.34.1
>

Re: [PATCH] pmdomain: starfive: Remove redundant dev_err()

Posted by Ulf Hansson 1 week, 1 day ago

On Thu, Jul 16, 2026 at 2:29 PM Ulf Hansson
<ulf.hansson@oss.qualcomm.com> wrote:
>
> On Thu, Jul 16, 2026 at 11:23 AM Pan Chuang <panchuang@vivo.com> wrote:
> >
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
>
> Applied for next, thanks!

As this causes a build warning, I have dropped the $subject patch from
my next branch.

[...]

Kind regards
Uffe