drm: fix unmet dependencies from missing GPIOLIB

[PATCH] drm: fix unmet dependencies from missing GPIOLIB

Posted by Julian Braha 1 week, 2 days ago

These 4 options, PINCTRL_PIC32, PINCTRL_PIC32, PINCTRL_IPROC_GPIO, and
PINCTRL_NSP_GPIO all select GPIOLIB_IRQCHIP without ensuring GPIOLIB is
enabled, causing unmet dependencies, such as:

WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
  Depends on [n]: GPIOLIB [=n]
  Selected by [y]:
  - PINCTRL_PIC32 [=y] && PINCTRL [=y] && OF [=y] && (MACH_PIC32 || COMPILE_TEST [=y])

Similar options in this subsystem select GPIOLIB, so let's do the same here.

These unmet dependency bugs were found by kconfirm, a static analysis tool for
Kconfig.

Fixes: 2ba384e6c381 ("pinctrl: pinctrl-pic32: Add PIC32 pin control driver")
Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
Fixes: b64333ce769c ("pinctrl: cygnus: add gpio/pinconf driver")
Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/pinctrl/Kconfig     | 2 ++
 drivers/pinctrl/bcm/Kconfig | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index c2cdd7b2c49b..ddc60562b770 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -486,6 +486,7 @@ config PINCTRL_PIC32
 	depends on MACH_PIC32 || COMPILE_TEST
 	select PINMUX
 	select GENERIC_PINCONF
+	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	help
 	  This is the pin controller and gpio driver for Microchip PIC32
@@ -562,6 +563,7 @@ config PINCTRL_STMFX
 	depends on I2C
 	depends on HAS_IOMEM
 	select GENERIC_PINCONF
+	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	select MFD_STMFX
 	help
diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index 206f3f1249cf..19d22e7fd11e 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -121,6 +121,7 @@ source "drivers/pinctrl/bcm/Kconfig.stb"
 config PINCTRL_IPROC_GPIO
 	bool "Broadcom iProc GPIO (with PINCONF) driver"
 	depends on ARCH_BCM_IPROC || COMPILE_TEST
+	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	select PINCONF
 	select GENERIC_PINCONF
@@ -186,6 +187,7 @@ config PINCTRL_NS
 config PINCTRL_NSP_GPIO
 	bool "Broadcom NSP GPIO (with PINCONF) driver"
 	depends on ARCH_BCM_NSP || COMPILE_TEST
+	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	select PINCONF
 	select GENERIC_PINCONF
-- 
2.54.0

Re: [PATCH] drm: fix unmet dependencies from missing GPIOLIB

Posted by Linus Walleij 18 hours ago

On Thu, Jul 16, 2026 at 5:34 AM Julian Braha <julianbraha@gmail.com> wrote:

> These 4 options, PINCTRL_PIC32, PINCTRL_PIC32, PINCTRL_IPROC_GPIO, and
> PINCTRL_NSP_GPIO all select GPIOLIB_IRQCHIP without ensuring GPIOLIB is
> enabled, causing unmet dependencies, such as:
>
> WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
>   Depends on [n]: GPIOLIB [=n]
>   Selected by [y]:
>   - PINCTRL_PIC32 [=y] && PINCTRL [=y] && OF [=y] && (MACH_PIC32 || COMPILE_TEST [=y])
>
> Similar options in this subsystem select GPIOLIB, so let's do the same here.
>
> These unmet dependency bugs were found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 2ba384e6c381 ("pinctrl: pinctrl-pic32: Add PIC32 pin control driver")
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Fixes: b64333ce769c ("pinctrl: cygnus: add gpio/pinconf driver")
> Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

Fixed up subject and applied as nonurgent fix, thanks!

Yours,
Linus Walleij

Re: [PATCH] drm: fix unmet dependencies from missing GPIOLIB

Posted by Arnd Bergmann 1 week, 2 days ago

On Thu, Jul 16, 2026, at 05:34, Julian Braha wrote:
> These 4 options, PINCTRL_PIC32, PINCTRL_PIC32, PINCTRL_IPROC_GPIO, and
> PINCTRL_NSP_GPIO all select GPIOLIB_IRQCHIP without ensuring GPIOLIB is
> enabled, causing unmet dependencies, such as:
>
> WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
>   Depends on [n]: GPIOLIB [=n]
>   Selected by [y]:
>   - PINCTRL_PIC32 [=y] && PINCTRL [=y] && OF [=y] && (MACH_PIC32 || 
> COMPILE_TEST [=y])
>
> Similar options in this subsystem select GPIOLIB, so let's do the same here.
>
> These unmet dependency bugs were found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 2ba384e6c381 ("pinctrl: pinctrl-pic32: Add PIC32 pin control 
> driver")
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO 
> driver")
> Fixes: b64333ce769c ("pinctrl: cygnus: add gpio/pinconf driver")
> Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for 
> Broadcom NSP SoC")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

The changes look fine, but the subject line is incorrectly
copied. With s/drm/pinctrl/, 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>