[PATCH] nvme-apple: Remove redundant dev_err_probe()

Pan Chuang posted 1 patch 1 week, 2 days ago
drivers/nvme/host/apple.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] nvme-apple: Remove redundant dev_err_probe()
Posted by Pan Chuang 1 week, 2 days ago
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/nvme/host/apple.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
index be3b91b43ea5..5770fb2657c8 100644
--- a/drivers/nvme/host/apple.c
+++ b/drivers/nvme/host/apple.c
@@ -1567,10 +1567,8 @@ static struct apple_nvme *apple_nvme_alloc(struct platform_device *pdev)
 
 	ret = devm_request_irq(anv->dev, anv->irq, apple_nvme_irq, 0,
 			       "nvme-apple", anv);
-	if (ret) {
-		dev_err_probe(dev, ret, "Failed to request IRQ");
+	if (ret)
 		goto put_dev;
-	}
 
 	anv->rtk =
 		devm_apple_rtkit_init(dev, anv, NULL, 0, &apple_nvme_rtkit_ops);
-- 
2.34.1
Re: [PATCH] nvme-apple: Remove redundant dev_err_probe()
Posted by Christoph Hellwig 5 days, 7 hours ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>