tools/perf/util/libbfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
The bfd_boolean type was gone and converted to the standard bool type
but we have some old code that uses the type. It caused a failure in
the build test.
util/libbfd.c: In function 'slurp_symtab':
util/libbfd.c:94:9: error: unknown type name 'bfd_boolean'
94 | bfd_boolean dynamic = FALSE;
| ^~~~~~~~~~~
util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this function)
94 | bfd_boolean dynamic = FALSE;
| ^~~~~
util/libbfd.c:94:31: note: each undeclared identifier is reported only once for each function it appears in
util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this function)
102 | dynamic = TRUE;
| ^~~~
Fix it with standard bool type and constants.
Link: https://sourceware.org/pipermail/binutils-cvs/2021-March/056231.html
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/libbfd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c
index c1c12308cc12ffea..d8241c7caac50836 100644
--- a/tools/perf/util/libbfd.c
+++ b/tools/perf/util/libbfd.c
@@ -91,7 +91,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l)
long storage;
long symcount;
asymbol **syms;
- bfd_boolean dynamic = FALSE;
+ bool dynamic = false;
if ((bfd_get_file_flags(abfd) & HAS_SYMS) == 0)
return bfd_error(bfd_get_filename(abfd));
@@ -99,7 +99,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l)
storage = bfd_get_symtab_upper_bound(abfd);
if (storage == 0L) {
storage = bfd_get_dynamic_symtab_upper_bound(abfd);
- dynamic = TRUE;
+ dynamic = true;
}
if (storage < 0L)
return bfd_error(bfd_get_filename(abfd));
--
2.55.0.141.g00534a21ce-googOn Wed, 15 Jul 2026 17:43:36 -0700, Namhyung Kim wrote: > The bfd_boolean type was gone and converted to the standard bool type > but we have some old code that uses the type. It caused a failure in > the build test. > > util/libbfd.c: In function 'slurp_symtab': > util/libbfd.c:94:9: error: unknown type name 'bfd_boolean' > 94 | bfd_boolean dynamic = FALSE; > | ^~~~~~~~~~~ > util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this function) > 94 | bfd_boolean dynamic = FALSE; > | ^~~~~ > util/libbfd.c:94:31: note: each undeclared identifier is reported only once for each function it appears in > util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this function) > 102 | dynamic = TRUE; > | ^~~~ > > [...] Applied to perf-tools-next, thanks! Best regards, Namhyung
On Wed, Jul 15, 2026 at 5:43 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The bfd_boolean type was gone and converted to the standard bool type
> but we have some old code that uses the type. It caused a failure in
> the build test.
>
> util/libbfd.c: In function 'slurp_symtab':
> util/libbfd.c:94:9: error: unknown type name 'bfd_boolean'
> 94 | bfd_boolean dynamic = FALSE;
> | ^~~~~~~~~~~
> util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this function)
> 94 | bfd_boolean dynamic = FALSE;
> | ^~~~~
> util/libbfd.c:94:31: note: each undeclared identifier is reported only once for each function it appears in
> util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this function)
> 102 | dynamic = TRUE;
> | ^~~~
>
> Fix it with standard bool type and constants.
>
> Link: https://sourceware.org/pipermail/binutils-cvs/2021-March/056231.html
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Should we add a fixes tag for backports? It's not clear we can provide
a sensible SHA.
Thanks,
Ian
> ---
> tools/perf/util/libbfd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c
> index c1c12308cc12ffea..d8241c7caac50836 100644
> --- a/tools/perf/util/libbfd.c
> +++ b/tools/perf/util/libbfd.c
> @@ -91,7 +91,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l)
> long storage;
> long symcount;
> asymbol **syms;
> - bfd_boolean dynamic = FALSE;
> + bool dynamic = false;
>
> if ((bfd_get_file_flags(abfd) & HAS_SYMS) == 0)
> return bfd_error(bfd_get_filename(abfd));
> @@ -99,7 +99,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l)
> storage = bfd_get_symtab_upper_bound(abfd);
> if (storage == 0L) {
> storage = bfd_get_dynamic_symtab_upper_bound(abfd);
> - dynamic = TRUE;
> + dynamic = true;
> }
> if (storage < 0L)
> return bfd_error(bfd_get_filename(abfd));
> --
> 2.55.0.141.g00534a21ce-goog
>
Hi Ian, On Wed, Jul 15, 2026 at 07:44:53PM -0700, Ian Rogers wrote: > On Wed, Jul 15, 2026 at 5:43 PM Namhyung Kim <namhyung@kernel.org> wrote: > > > > The bfd_boolean type was gone and converted to the standard bool type > > but we have some old code that uses the type. It caused a failure in > > the build test. > > > > util/libbfd.c: In function 'slurp_symtab': > > util/libbfd.c:94:9: error: unknown type name 'bfd_boolean' > > 94 | bfd_boolean dynamic = FALSE; > > | ^~~~~~~~~~~ > > util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this function) > > 94 | bfd_boolean dynamic = FALSE; > > | ^~~~~ > > util/libbfd.c:94:31: note: each undeclared identifier is reported only once for each function it appears in > > util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this function) > > 102 | dynamic = TRUE; > > | ^~~~ > > > > Fix it with standard bool type and constants. > > > > Link: https://sourceware.org/pipermail/binutils-cvs/2021-March/056231.html > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > Reviewed-by: Ian Rogers <irogers@google.com> > > Should we add a fixes tag for backports? It's not clear we can provide > a sensible SHA. Thanks for your review. Yep, the file was moved and it had the bug before. I was thinking about adding SHA of the move but not sure if it's really worth it. Thanks, Namhyung
© 2016 - 2026 Red Hat, Inc.