On Wed, Jul 15, 2026 at 10:02:13PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2026 at 07:52:16PM +0200, Link Mauve wrote:
> > This callback used to take a mutable void * for no reason, which causes
> > the compiler to be unaware that the val buffer should never be modified
> > by the callback.
> >
> > This was found while drafting the nvmem-provider Rust abstraction.
> >
> > I’ve split this series based on the subsystem each patch affects, but I
> > think it should go through the nvmem tree in one go after gathering the
> > acks from the other subsystem maintainers.
>
> It's an option. The other option (and often we go this way) is to introduce
> a new name, convert users, convert the name back.
>
> See, for example, how GPIO subsystem changed a proto of .set() callback.
I agree with Andy. This should be a well-narrowed bisectable series,
so please follow his suggestion with renaming.
> > I’ve been told previously to not include too many maintainers in Cc, but
> > I don’t know which ones to remove from the get_maintainers.pl output, so
> > I’ve still included everyone, sorry about that.
>
> With this, rather standard, way you will fulfill the above requirement
> automatically. Also you won't need treewide change to bother everybody
> with this. And also increase the chances to go in (maybe in a few releases
> span).
If I feel the recepient list is too long, I have a couple home-brewed scripts
for it:
$ cat add_maintainers.sh
#!/bin/bash
line=`scripts/get_maintainer.pl -n -f --separator , --no-rolestats $1`
sed -i "/^Subject:/i To: $line" $1
sed -i "s/>,/>,\n\t/g" $1
and
$ cat addm.sh
#!/bin/bash
for f in 00*; do
echo $f
./add_maintainers.sh $f
done
So, my approach is:
1. Run the ./addm.sh
2. Pick maintainers from each patch, and put them in the cover letter.
3. Trim cover letter To list, if needed.
The disadvantage of this approach is that people may receive a part of
the series, so for example can't apply it cleanly for testing. But now
that everyone has b4, fetching everything is as simple as
b4 mbox <message-id>
Thanks,
Yury