[v2] io: accel: mma8452: Allow open drain interrupt pin configuration

[PATCH v2 0/3] io: accel: mma8452: Allow open drain interrupt pin configuration

Posted by Esben Haabendal 1 week, 3 days ago

Extend the mma8452 driver with support for configuration of the
interrupt line in open-drain mode, which is needed for hardware designs
where the interrupt line is shared with other chips.

Adding drive-open-drain property to mma8452 device-tree node for such
designs to enable switching pin configuration to open-drain mode.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
Changes in v2:
- Commit message of patch 2 updated.
- Operator precedence bug fixed in flags argument to
  request_threaded_irq().
- Always check return value of mma8452_set_interrupt_pin_mode(), and just
  check for non-zero value.
- Added new patch with optimization of struct mma8452_data ordering.
- Link to v1: https://patch.msgid.link/20260715-mma8452-open-drain-v1-0-b1dd2a440c60@geanix.com

To: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Martin Kepplinger <martink@posteo.de>
To: Sean Nyekjaer <sean@geanix.com>
To: David Lechner <dlechner@baylibre.com>
To: Nuno Sá <nuno.sa@analog.com>
To: Andy Shevchenko <andy@kernel.org>
To: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
Cc: linux-iio@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
Esben Haabendal (3):
      dt-bindings: iio: accel: mma8452: Add drive-open-drain
      iio: accel: mma8452: Allow open drain interrupt pin configuration
      iio: accel: mma8452: Optimize struct mm8452_data member orders

 .../devicetree/bindings/iio/accel/fsl,mma8452.yaml |  6 ++++
 drivers/iio/accel/mma8452.c                        | 38 +++++++++++++++++++---
 2 files changed, 40 insertions(+), 4 deletions(-)
---
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
change-id: 20250401-mma8452-open-drain-81577c41375c

Best regards,
--  
Esben Haabendal <esben@geanix.com>

Re: [PATCH v2 0/3] io: accel: mma8452: Allow open drain interrupt pin configuration

Posted by Andy Shevchenko 1 week, 3 days ago

On Wed, Jul 15, 2026 at 02:33:26PM +0200, Esben Haabendal wrote:
> Extend the mma8452 driver with support for configuration of the
> interrupt line in open-drain mode, which is needed for hardware designs
> where the interrupt line is shared with other chips.
> 
> Adding drive-open-drain property to mma8452 device-tree node for such
> designs to enable switching pin configuration to open-drain mode.

NAK.

Please, do not send a new version until everything is settled down in the
previous round. Let's continue discussion in v1.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/3] io: accel: mma8452: Allow open drain interrupt pin configuration

Posted by Jonathan Cameron 6 days, 15 hours ago

On Wed, 15 Jul 2026 16:55:29 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jul 15, 2026 at 02:33:26PM +0200, Esben Haabendal wrote:
> > Extend the mma8452 driver with support for configuration of the
> > interrupt line in open-drain mode, which is needed for hardware designs
> > where the interrupt line is shared with other chips.
> > 
> > Adding drive-open-drain property to mma8452 device-tree node for such
> > designs to enable switching pin configuration to open-drain mode.  
> 
> NAK.
> 
> Please, do not send a new version until everything is settled down in the
> previous round. Let's continue discussion in v1.
> 

Even if the conversation there hadn't been ongoing, please slow down
with new versions.  At least 24 hours, preferably a week between versions
of anything non trivial (and this turned out not to be!)

Jonathan