In qla_edif_bsg.h: `struct fc_bsg_reply` and `struct fc_bsg_request`
have flexible array members, thus they must be the last member of
the parent structure. Contininging in the effort to add
`-Wflex-array-member-not-at-end`, move the structs to the end of
the parent structures, `struct qla_bsg_auth_els_reply` and
`struct qla_bsg_auth_els_request `.
Suggested-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
---
drivers/scsi/qla2xxx/qla_edif_bsg.h | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_edif_bsg.h b/drivers/scsi/qla2xxx/qla_edif_bsg.h
index 514c265ba86e..2b32a3185629 100644
--- a/drivers/scsi/qla2xxx/qla_edif_bsg.h
+++ b/drivers/scsi/qla2xxx/qla_edif_bsg.h
@@ -36,16 +36,26 @@ struct extra_auth_els {
} __packed;
struct qla_bsg_auth_els_request {
- struct fc_bsg_request r;
- struct extra_auth_els e;
+ union {
+ struct fc_bsg_request r;
+ struct {
+ unsigned char __fc_bsg_request_sz[sizeof(struct fc_bsg_request)];
+ struct extra_auth_els e;
+ };
+ };
};
struct qla_bsg_auth_els_reply {
- struct fc_bsg_reply r;
- uint32_t rx_xchg_address;
- uint8_t version;
- uint8_t pad[VND_CMD_PAD_SIZE];
- uint8_t reserved[VND_CMD_APP_RESERVED_SIZE];
+ union {
+ struct fc_bsg_reply r;
+ struct {
+ unsigned char __fc_bsg_reply_sz[sizeof(struct fc_bsg_reply)];
+ uint32_t rx_xchg_address;
+ uint8_t version;
+ uint8_t pad[VND_CMD_PAD_SIZE];
+ uint8_t reserved[VND_CMD_APP_RESERVED_SIZE];
+ };
+ };
};
struct app_id {
--
2.54.0