1. Patchew
  2. linux
  3. View series

[PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64

Marek Vasut posted 1 patch 1 week, 4 days ago 
drivers/pci/controller/dwc/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64
Posted by Marek Vasut 1 week, 4 days ago 
The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers
which are available only on ARM and ARM64, on other architectures the
headers are not present and the driver fails to build. This driver is
used only on ARM64 hardware, isolate its build only to ARM64 to avoid
build failures on other architectures.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@intel.com/
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
V2: This is a rework of PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
    which isolates the driver build to ARM64 via Kconfig instead:
    https://lore.kernel.org/linux-pci/CAMuHMdVvWE7YZgKvreSn_vJLOVD4eMmn3TCGOyqSXksqjBCwvg@mail.gmail.com/
    https://lore.kernel.org/linux-pci/20260714110041.GA1349622@bhelgaas/
---
 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 49a7a2c50ca15..3260d916110b2 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -346,7 +346,7 @@ config PCIE_RCAR_GEN4
 
 config PCIE_RCAR_GEN4_HOST
 	tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
-	depends on ARCH_RENESAS || COMPILE_TEST
+	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
 	depends on PCI_MSI
 	select PCIE_DW_HOST
 	select PCIE_RCAR_GEN4
@@ -357,7 +357,7 @@ config PCIE_RCAR_GEN4_HOST
 
 config PCIE_RCAR_GEN4_EP
 	tristate "Renesas R-Car Gen4 PCIe controller (endpoint mode)"
-	depends on ARCH_RENESAS || COMPILE_TEST
+	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PCIE_RCAR_GEN4
-- 
2.53.0
Re: [PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64
Posted by Bjorn Helgaas 1 week, 3 days ago 
On Tue, Jul 14, 2026 at 03:19:27PM +0200, Marek Vasut wrote:
> The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers
> which are available only on ARM and ARM64, on other architectures the
> headers are not present and the driver fails to build. This driver is
> used only on ARM64 hardware, isolate its build only to ARM64 to avoid
> build failures on other architectures.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@intel.com/
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Mani, I assume you'll squash this into 89bded511a66 ("PCI: rcar-gen4:
Configure AXIINTC if iMSI-RX is not used") so it's connected to the
addition of the linux/irqchip/arm-gic-v3.h include and there's no
bisection hole?

> ---
> Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: This is a rework of PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
>     which isolates the driver build to ARM64 via Kconfig instead:
>     https://lore.kernel.org/linux-pci/CAMuHMdVvWE7YZgKvreSn_vJLOVD4eMmn3TCGOyqSXksqjBCwvg@mail.gmail.com/
>     https://lore.kernel.org/linux-pci/20260714110041.GA1349622@bhelgaas/
> ---
>  drivers/pci/controller/dwc/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 49a7a2c50ca15..3260d916110b2 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -346,7 +346,7 @@ config PCIE_RCAR_GEN4
>  
>  config PCIE_RCAR_GEN4_HOST
>  	tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
> -	depends on ARCH_RENESAS || COMPILE_TEST
> +	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
>  	depends on PCI_MSI
>  	select PCIE_DW_HOST
>  	select PCIE_RCAR_GEN4
> @@ -357,7 +357,7 @@ config PCIE_RCAR_GEN4_HOST
>  
>  config PCIE_RCAR_GEN4_EP
>  	tristate "Renesas R-Car Gen4 PCIe controller (endpoint mode)"
> -	depends on ARCH_RENESAS || COMPILE_TEST
> +	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
>  	depends on PCI_ENDPOINT
>  	select PCIE_DW_EP
>  	select PCIE_RCAR_GEN4
> -- 
> 2.53.0
>
Re: [PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64
Posted by Manivannan Sadhasivam 1 week, 3 days ago 
On Tue, Jul 14, 2026 at 04:10:30PM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 14, 2026 at 03:19:27PM +0200, Marek Vasut wrote:
> > The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers
> > which are available only on ARM and ARM64, on other architectures the
> > headers are not present and the driver fails to build. This driver is
> > used only on ARM64 hardware, isolate its build only to ARM64 to avoid
> > build failures on other architectures.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@intel.com/
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> 
> Mani, I assume you'll squash this into 89bded511a66 ("PCI: rcar-gen4:
> Configure AXIINTC if iMSI-RX is not used") so it's connected to the
> addition of the linux/irqchip/arm-gic-v3.h include and there's no
> bisection hole?
> 

Yes, squashed now!

- Mani

> > ---
> > Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: Manivannan Sadhasivam <mani@kernel.org>
> > Cc: Marc Zyngier <maz@kernel.org>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-renesas-soc@vger.kernel.org
> > ---
> > V2: This is a rework of PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
> >     which isolates the driver build to ARM64 via Kconfig instead:
> >     https://lore.kernel.org/linux-pci/CAMuHMdVvWE7YZgKvreSn_vJLOVD4eMmn3TCGOyqSXksqjBCwvg@mail.gmail.com/
> >     https://lore.kernel.org/linux-pci/20260714110041.GA1349622@bhelgaas/
> > ---
> >  drivers/pci/controller/dwc/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 49a7a2c50ca15..3260d916110b2 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -346,7 +346,7 @@ config PCIE_RCAR_GEN4
> >  
> >  config PCIE_RCAR_GEN4_HOST
> >  	tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
> > -	depends on ARCH_RENESAS || COMPILE_TEST
> > +	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
> >  	depends on PCI_MSI
> >  	select PCIE_DW_HOST
> >  	select PCIE_RCAR_GEN4
> > @@ -357,7 +357,7 @@ config PCIE_RCAR_GEN4_HOST
> >  
> >  config PCIE_RCAR_GEN4_EP
> >  	tristate "Renesas R-Car Gen4 PCIe controller (endpoint mode)"
> > -	depends on ARCH_RENESAS || COMPILE_TEST
> > +	depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
> >  	depends on PCI_ENDPOINT
> >  	select PCIE_DW_EP
> >  	select PCIE_RCAR_GEN4
> > -- 
> > 2.53.0
> > 

-- 
மணிவண்ணன் சதாசிவம்
Re: [PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64
Posted by Marek Vasut 1 week, 3 days ago 
On 7/15/26 4:03 PM, Manivannan Sadhasivam wrote:
> On Tue, Jul 14, 2026 at 04:10:30PM -0500, Bjorn Helgaas wrote:
>> On Tue, Jul 14, 2026 at 03:19:27PM +0200, Marek Vasut wrote:
>>> The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers
>>> which are available only on ARM and ARM64, on other architectures the
>>> headers are not present and the driver fails to build. This driver is
>>> used only on ARM64 hardware, isolate its build only to ARM64 to avoid
>>> build failures on other architectures.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@intel.com/
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>
>> Mani, I assume you'll squash this into 89bded511a66 ("PCI: rcar-gen4:
>> Configure AXIINTC if iMSI-RX is not used") so it's connected to the
>> addition of the linux/irqchip/arm-gic-v3.h include and there's no
>> bisection hole?
>>
> 
> Yes, squashed now!
Thank you both.

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.