irqchip: Remove redundant dev_err()/dev_err_probe()

[PATCH] irqchip: Remove redundant dev_err()/dev_err_probe()

Posted by Pan Chuang 1 week, 4 days ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/irqchip/irq-qcom-mpm.c      | 4 +---
 drivers/irqchip/irq-renesas-rzt2h.c | 2 +-
 drivers/irqchip/irq-renesas-rzv2h.c | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
index 181320528a47..8c575d7ce8a1 100644
--- a/drivers/irqchip/irq-qcom-mpm.c
+++ b/drivers/irqchip/irq-qcom-mpm.c
@@ -464,10 +464,8 @@ static int qcom_mpm_probe(struct platform_device *pdev, struct device_node *pare
 
 	ret = devm_request_irq(dev, irq, qcom_mpm_handler, IRQF_NO_SUSPEND,
 			       "qcom_mpm", priv);
-	if (ret) {
-		dev_err(dev, "failed to request irq: %d\n", ret);
+	if (ret)
 		goto remove_domain;
-	}
 
 	return 0;
 
diff --git a/drivers/irqchip/irq-renesas-rzt2h.c b/drivers/irqchip/irq-renesas-rzt2h.c
index e06264add3cc..9086fc3a2043 100644
--- a/drivers/irqchip/irq-renesas-rzt2h.c
+++ b/drivers/irqchip/irq-renesas-rzt2h.c
@@ -398,7 +398,7 @@ static int rzt2h_icu_request_irqs(struct platform_device *pdev, struct irq_domai
 		ret = devm_request_irq(dev, virq, handler, 0, dev_name(dev),
 				       data ?: (void *)(uintptr_t)offset);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request IRQ %u\n", offset);
+			return ret;
 	}
 
 	return 0;
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 971ac83eee90..1a4703a353e9 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -816,7 +816,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
 		ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
 				       (void *)(uintptr_t)i);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n", i);
+			return ret;
 	}
 
 	/* Unmask and clear all IP/CA55 error interrupts */
@@ -844,7 +844,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
 
 	ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
 	if (ret)
-		return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n");
+		return ret;
 
 	return 0;
 }
-- 
2.34.1

Re: [PATCH] irqchip: Remove redundant dev_err()/dev_err_probe()

Posted by Radu Rendec 1 week, 3 days ago

On Tue, 2026-07-14 at 21:13 +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
>  drivers/irqchip/irq-qcom-mpm.c      | 4 +---
>  drivers/irqchip/irq-renesas-rzt2h.c | 2 +-
>  drivers/irqchip/irq-renesas-rzv2h.c | 4 ++--
>  3 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
> index 181320528a47..8c575d7ce8a1 100644
> --- a/drivers/irqchip/irq-qcom-mpm.c
> +++ b/drivers/irqchip/irq-qcom-mpm.c
> @@ -464,10 +464,8 @@ static int qcom_mpm_probe(struct platform_device *pdev, struct device_node *pare
>  
>  	ret = devm_request_irq(dev, irq, qcom_mpm_handler, IRQF_NO_SUSPEND,
>  			       "qcom_mpm", priv);
> -	if (ret) {
> -		dev_err(dev, "failed to request irq: %d\n", ret);
> +	if (ret)
>  		goto remove_domain;
> -	}
>  
>  	return 0;
>  
> diff --git a/drivers/irqchip/irq-renesas-rzt2h.c b/drivers/irqchip/irq-renesas-rzt2h.c
> index e06264add3cc..9086fc3a2043 100644
> --- a/drivers/irqchip/irq-renesas-rzt2h.c
> +++ b/drivers/irqchip/irq-renesas-rzt2h.c
> @@ -398,7 +398,7 @@ static int rzt2h_icu_request_irqs(struct platform_device *pdev, struct irq_domai
>  		ret = devm_request_irq(dev, virq, handler, 0, dev_name(dev),
>  				       data ?: (void *)(uintptr_t)offset);
>  		if (ret)
> -			return dev_err_probe(dev, ret, "Failed to request IRQ %u\n", offset);
> +			return ret;
>  	}
>  
>  	return 0;
> diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
> index 971ac83eee90..1a4703a353e9 100644
> --- a/drivers/irqchip/irq-renesas-rzv2h.c
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> @@ -816,7 +816,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
>  		ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
>  				       (void *)(uintptr_t)i);
>  		if (ret)
> -			return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n", i);
> +			return ret;
>  	}
>  
>  	/* Unmask and clear all IP/CA55 error interrupts */
> @@ -844,7 +844,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain
>  
>  	ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
>  	if (ret)
> -		return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n");
> +		return ret;
>  
>  	return 0;
>  }

Reviewed-by: Radu Rendec <radu@rendec.net>

[tip: irq/drivers] irqchip: Remove redundant dev_err()/dev_err_probe()

Posted by tip-bot2 for Pan Chuang 1 week, 3 days ago

The following commit has been merged into the irq/drivers branch of tip:

Commit-ID:     9023960b74ab32bef73273cfb5bff3b0b70d5ef8
Gitweb:        https://git.kernel.org/tip/9023960b74ab32bef73273cfb5bff3b0b70d5ef8
Author:        Pan Chuang <panchuang@vivo.com>
AuthorDate:    Tue, 14 Jul 2026 21:13:30 +08:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Wed, 15 Jul 2026 08:40:22 +02:00

irqchip: Remove redundant dev_err()/dev_err_probe()

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Radu Rendec <radu@rendec.net>
Link: https://patch.msgid.link/20260714131331.494902-1-panchuang@vivo.com
---
 drivers/irqchip/irq-qcom-mpm.c      | 4 +---
 drivers/irqchip/irq-renesas-rzt2h.c | 2 +-
 drivers/irqchip/irq-renesas-rzv2h.c | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
index 1813205..8c575d7 100644
--- a/drivers/irqchip/irq-qcom-mpm.c
+++ b/drivers/irqchip/irq-qcom-mpm.c
@@ -464,10 +464,8 @@ static int qcom_mpm_probe(struct platform_device *pdev, struct device_node *pare
 
 	ret = devm_request_irq(dev, irq, qcom_mpm_handler, IRQF_NO_SUSPEND,
 			       "qcom_mpm", priv);
-	if (ret) {
-		dev_err(dev, "failed to request irq: %d\n", ret);
+	if (ret)
 		goto remove_domain;
-	}
 
 	return 0;
 
diff --git a/drivers/irqchip/irq-renesas-rzt2h.c b/drivers/irqchip/irq-renesas-rzt2h.c
index e06264a..9086fc3 100644
--- a/drivers/irqchip/irq-renesas-rzt2h.c
+++ b/drivers/irqchip/irq-renesas-rzt2h.c
@@ -398,7 +398,7 @@ static int rzt2h_icu_request_irqs(struct platform_device *pdev, struct irq_domai
 		ret = devm_request_irq(dev, virq, handler, 0, dev_name(dev),
 				       data ?: (void *)(uintptr_t)offset);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request IRQ %u\n", offset);
+			return ret;
 	}
 
 	return 0;
diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 971ac83..1a4703a 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -816,7 +816,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain 
 		ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev),
 				       (void *)(uintptr_t)i);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n", i);
+			return ret;
 	}
 
 	/* Unmask and clear all IP/CA55 error interrupts */
@@ -844,7 +844,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain 
 
 	ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
 	if (ret)
-		return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n");
+		return ret;
 
 	return 0;
 }