[v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE

[PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE

Julian Braha posted 1 patch 1 week, 4 days ago

Diff against v2
Download mbox

drivers/usb/musb/Kconfig | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE

Posted by Julian Braha 1 week, 4 days ago

'select' does not work on config options in a 'choice', so currently it is
possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.

Remove the dead select, as it is unnecessary, from this conversation:
https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/

This dead select was found by kconfirm, a static analysis tool for Kconfig.

Suggested-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: remove 'select' instead of changing to dependency  
Link: https://lore.kernel.org/all/20260711130349.592545-1-julianbraha@gmail.com/

 drivers/usb/musb/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f56929267eaa..1b0d27d8e02f 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -116,7 +116,6 @@ config USB_MUSB_POLARFIRE_SOC
 	tristate "Microchip PolarFire SoC platforms"
 	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
 	depends on NOP_USB_XCEIV
-	select USB_MUSB_DUAL_ROLE
 	help
 	  Say Y here to enable support for USB on Microchip's PolarFire SoC.
 
-- 
2.54.0