[PATCH] tools/sched_ext: scx_qmap: Fix stale API name in comment

luoliang@kylinos.cn posted 1 patch 1 week, 4 days ago
tools/sched_ext/scx_qmap.bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tools/sched_ext: scx_qmap: Fix stale API name in comment
Posted by luoliang@kylinos.cn 1 week, 4 days ago
From: Liang Luo <luoliang@kylinos.cn>

The comment above dispatch_highpri() still references
scx_bpf_dispatch[_vtime]_from_dsq(), which was renamed to
scx_bpf_dsq_move[_vtime]() in v6.13 to unload the overloaded
"dispatch" verb. The code below already uses the new names; only the
comment was left behind during the rename.

Fixes: 5cbb302880f5 ("sched_ext: Rename scx_bpf_dispatch[_vtime]_from_dsq*() -> scx_bpf_dsq_move[_vtime]*()")
Signed-off-by: Liang Luo <luoliang@kylinos.cn>
---
 tools/sched_ext/scx_qmap.bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/sched_ext/scx_qmap.bpf.c b/tools/sched_ext/scx_qmap.bpf.c
index fd9a82a67627..05f88d819b40 100644
--- a/tools/sched_ext/scx_qmap.bpf.c
+++ b/tools/sched_ext/scx_qmap.bpf.c
@@ -495,7 +495,7 @@ static void update_core_sched_head_seq(struct task_struct *p)
  * moving them to HIGHPRI_DSQ and then consuming them first. This makes minor
  * difference only when dsp_batch is larger than 1.
  *
- * scx_bpf_dispatch[_vtime]_from_dsq() are allowed both from ops.dispatch() and
+ * scx_bpf_dsq_move[_vtime]() are allowed both from ops.dispatch() and
  * non-rq-lock holding BPF programs. As demonstration, this function is called
  * from qmap_dispatch() and monitor_timerfn().
  */
-- 
2.43.0
Re: [PATCH] tools/sched_ext: scx_qmap: Fix stale API name in comment
Posted by Tejun Heo 1 week, 3 days ago
Hello, Liang.

Applied to sched_ext/for-7.3.

Thanks.

-- 
tejun