[PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld

Ninad Naik posted 1 patch 1 week, 5 days ago
drivers/leds/blink/leds-bcm63138.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
Posted by Ninad Naik 1 week, 5 days ago
Pass the pinctrl error pointer directly to %pe to print the
symbolic error name.
Detected by Coccinelle. Tested by compiling.

Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
 drivers/leds/blink/leds-bcm63138.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c
index 45c0662df933..12b70ee31b9a 100644
--- a/drivers/leds/blink/leds-bcm63138.c
+++ b/drivers/leds/blink/leds-bcm63138.c
@@ -236,8 +236,8 @@ static void bcm63138_leds_create_led(struct bcm63138_leds *leds,
 
 	pinctrl = devm_pinctrl_get_select_default(led->cdev.dev);
 	if (IS_ERR(pinctrl) && PTR_ERR(pinctrl) != -ENODEV) {
-		dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %ld\n",
-			 np, PTR_ERR(pinctrl));
+		dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %pe\n",
+			 np, pinctrl);
 	}
 
 	bit = BIT(led->pin);
-- 
2.55.0
Re: (subset) [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
Posted by Lee Jones 2 days, 7 hours ago
On Tue, 14 Jul 2026 01:37:32 +0530, Ninad Naik wrote:
> Pass the pinctrl error pointer directly to %pe to print the
> symbolic error name.
> Detected by Coccinelle. Tested by compiling.

Applied, thanks!

[1/1] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
      commit: b6e08e0ad4cfafab2c2070456e7eeba17608a35d

--
Lee Jones [李琼斯]