Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/fpga/zynq-fpga.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 9d1d599ef718..2f8ba32e4002 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
 	err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
 			       priv);
 	if (err) {
-		dev_err(dev, "unable to request IRQ\n");
 		clk_disable_unprepare(priv->clk);
 		return err;
 	}
-- 
2.34.1

On 7/13/26 15:22, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
>   drivers/fpga/zynq-fpga.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 9d1d599ef718..2f8ba32e4002 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>   	err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
>   			       priv);
>   	if (err) {
> -		dev_err(dev, "unable to request IRQ\n");
>   		clk_disable_unprepare(priv->clk);
>   		return err;
>   	}

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

On Mon, Jul 13, 2026 at 03:48:57PM +0200, Michal Simek wrote:
> 
> 
> On 7/13/26 15:22, Pan Chuang wrote:
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> > 
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> > ---
> >   drivers/fpga/zynq-fpga.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> > index 9d1d599ef718..2f8ba32e4002 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> >   	err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
> >   			       priv);
> >   	if (err) {
> > -		dev_err(dev, "unable to request IRQ\n");
> >   		clk_disable_unprepare(priv->clk);
> >   		return err;
> >   	}
> 
> Reviewed-by: Michal Simek <michal.simek@amd.com>

Reviewed-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next. Thanks for the patch and the review!