firmware: qcom: Remove redundant dev_err_probe()

[PATCH] firmware: qcom: Remove redundant dev_err_probe()

Posted by Pan Chuang 1 week, 5 days ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/firmware/qcom/qcom_scm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 6b601a4b89db..fad3e73791ac 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -2822,8 +2822,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
 		ret = devm_request_threaded_irq(scm->dev, irq, NULL, qcom_scm_irq_handler,
 						IRQF_ONESHOT, "qcom-scm", scm);
 		if (ret < 0)
-			return dev_err_probe(scm->dev, ret,
-					     "Failed to request qcom-scm irq\n");
+			return ret;
 	}
 
 	/*
-- 
2.34.1

[PATCH] firmware: tegra: Remove redundant dev_err()

Posted by Pan Chuang 1 week, 5 days ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/firmware/tegra/bpmp-tegra210.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c
index 6295f5640c15..643068a8b3b8 100644
--- a/drivers/firmware/tegra/bpmp-tegra210.c
+++ b/drivers/firmware/tegra/bpmp-tegra210.c
@@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
 
 	err = devm_request_irq(&pdev->dev, err, rx_irq,
 			       IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp);
-	if (err < 0) {
-		dev_err(&pdev->dev, "failed to request IRQ: %d\n", err);
+	if (err < 0)
 		return err;
-	}
 
 	return 0;
 }
-- 
2.34.1

Re: [PATCH] firmware: tegra: Remove redundant dev_err()

Posted by Mikko Perttunen 1 week, 3 days ago

On Monday, July 13, 2026 10:19 PM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
>  drivers/firmware/tegra/bpmp-tegra210.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c
> index 6295f5640c15..643068a8b3b8 100644
> --- a/drivers/firmware/tegra/bpmp-tegra210.c
> +++ b/drivers/firmware/tegra/bpmp-tegra210.c
> @@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
>  
>  	err = devm_request_irq(&pdev->dev, err, rx_irq,
>  			       IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp);
> -	if (err < 0) {
> -		dev_err(&pdev->dev, "failed to request IRQ: %d\n", err);
> +	if (err < 0)
>  		return err;
> -	}
>  
>  	return 0;
>  }
> -- 
> 2.34.1
> 
> 

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>