cpufreq: Remove redundant dev_err()

[PATCH] cpufreq: Remove redundant dev_err()

Posted by Pan Chuang 1 week, 5 days ago

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/cpufreq/brcmstb-avs-cpufreq.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 71450cca8e9f..7d902856ac01 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -584,11 +584,8 @@ static int brcm_avs_prepare_init(struct platform_device *pdev)
 	ret = devm_request_irq(dev, priv->host_irq, irq_handler,
 			       IRQF_TRIGGER_RISING,
 			       BRCM_AVS_HOST_INTR, priv);
-	if (ret && priv->host_irq >= 0) {
-		dev_err(dev, "IRQ request failed: %s (%d) -- %d\n",
-			BRCM_AVS_HOST_INTR, priv->host_irq, ret);
+	if (ret && priv->host_irq >= 0)
 		goto unmap_intr_base;
-	}
 
 	if (brcm_avs_is_firmware_loaded(priv))
 		return 0;
-- 
2.34.1

Re: [PATCH] cpufreq: Remove redundant dev_err()

Posted by Zhongqiu Han 1 week, 4 days ago

On 7/13/2026 9:11 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>

Looks good to me overall.

However the subject is too generic and can be misread as a cpufreq core
fix. Please scope it to the driver, e.g:
"cpufreq: brcmstb-avs: Remove redundant dev_err() on IRQ request failure".

With that:

Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>


> ---
>   drivers/cpufreq/brcmstb-avs-cpufreq.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
> index 71450cca8e9f..7d902856ac01 100644
> --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
> +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
> @@ -584,11 +584,8 @@ static int brcm_avs_prepare_init(struct platform_device *pdev)
>   	ret = devm_request_irq(dev, priv->host_irq, irq_handler,
>   			       IRQF_TRIGGER_RISING,
>   			       BRCM_AVS_HOST_INTR, priv);
> -	if (ret && priv->host_irq >= 0) {
> -		dev_err(dev, "IRQ request failed: %s (%d) -- %d\n",
> -			BRCM_AVS_HOST_INTR, priv->host_irq, ret);
> +	if (ret && priv->host_irq >= 0)
>   		goto unmap_intr_base;
> -	}
>   
>   	if (brcm_avs_is_firmware_loaded(priv))
>   		return 0;


-- 
Thx and BRs,
Zhongqiu Han

Re: [PATCH] cpufreq: Remove redundant dev_err()

Posted by Viresh Kumar 1 week, 4 days ago

On 14-07-26, 10:39, Zhongqiu Han wrote:
> On 7/13/2026 9:11 PM, Pan Chuang wrote:
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> > 
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> 
> Looks good to me overall.
> 
> However the subject is too generic and can be misread as a cpufreq core
> fix. Please scope it to the driver, e.g:
> "cpufreq: brcmstb-avs: Remove redundant dev_err() on IRQ request failure".

Fixed.

> With that:
> 
> Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>

Applied. Thanks.

-- 
viresh