dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

[PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

Posted by Marek Szyprowski 1 week, 5 days ago

Improve readability of the sg_dma_len assignment in the P2PDMA cases by
removing duplicated code, which was a direct result of the d0d08f4bd7f6
("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings")
fix. No functional change.

Suggested-by: Leon Romanovsky <leon@kernel.org>
Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 kernel/dma/direct.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
index 4391b797d4db..d8219efe3273 100644
--- a/kernel/dma/direct.c
+++ b/kernel/dma/direct.c
@@ -486,15 +486,14 @@ int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl, int nents,
 				goto out_unmap;
 			}
 			break;
 		case PCI_P2PDMA_MAP_BUS_ADDR:
 			sg->dma_address = pci_p2pdma_bus_addr_map(
 				p2pdma_state.mem, sg_phys(sg));
-			sg_dma_len(sg) = sg->length;
 			sg_dma_mark_bus_address(sg);
-			continue;
+			break;
 		default:
 			ret = -EREMOTEIO;
 			goto out_unmap;
 		}
 		sg_dma_len(sg) = sg->length;
 	}
-- 
2.34.1

Re: [PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

Posted by Pranjal Shrivastava 1 week, 4 days ago

On Mon, Jul 13, 2026 at 10:30:22AM +0200, Marek Szyprowski wrote:
> Improve readability of the sg_dma_len assignment in the P2PDMA cases by
> removing duplicated code, which was a direct result of the d0d08f4bd7f6
> ("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings")
> fix. No functional change.
> 
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  kernel/dma/direct.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
> index 4391b797d4db..d8219efe3273 100644
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -486,15 +486,14 @@ int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl, int nents,
>  				goto out_unmap;
>  			}
>  			break;
>  		case PCI_P2PDMA_MAP_BUS_ADDR:
>  			sg->dma_address = pci_p2pdma_bus_addr_map(
>  				p2pdma_state.mem, sg_phys(sg));
> -			sg_dma_len(sg) = sg->length;
>  			sg_dma_mark_bus_address(sg);
> -			continue;
> +			break;
>  		default:
>  			ret = -EREMOTEIO;
>  			goto out_unmap;
>  		}
>  		sg_dma_len(sg) = sg->length;
>  	}

Reviewed-by: Pranjal Shrivastava <praan@google.com>

Thanks,
Praan

Re: [PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

Posted by Marek Szyprowski 1 week, 4 days ago

On 13.07.2026 10:30, Marek Szyprowski wrote:
> Improve readability of the sg_dma_len assignment in the P2PDMA cases by
> removing duplicated code, which was a direct result of the d0d08f4bd7f6
> ("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings")
> fix. No functional change.
>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Pushed to dma-mapping-for-next.
> ---
>  kernel/dma/direct.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
> index 4391b797d4db..d8219efe3273 100644
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -486,15 +486,14 @@ int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl, int nents,
>  				goto out_unmap;
>  			}
>  			break;
>  		case PCI_P2PDMA_MAP_BUS_ADDR:
>  			sg->dma_address = pci_p2pdma_bus_addr_map(
>  				p2pdma_state.mem, sg_phys(sg));
> -			sg_dma_len(sg) = sg->length;
>  			sg_dma_mark_bus_address(sg);
> -			continue;
> +			break;
>  		default:
>  			ret = -EREMOTEIO;
>  			goto out_unmap;
>  		}
>  		sg_dma_len(sg) = sg->length;
>  	}

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Re: [PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

Posted by Logan Gunthorpe 1 week, 5 days ago


On 2026-07-13 02:30, Marek Szyprowski wrote:
> Improve readability of the sg_dma_len assignment in the P2PDMA cases by
> removing duplicated code, which was a direct result of the d0d08f4bd7f6
> ("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings")
> fix. No functional change.
> 
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Looks good to me, thanks.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Re: [PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case

Posted by Leon Romanovsky 1 week, 5 days ago

On Mon, Jul 13, 2026 at 10:30:22AM +0200, Marek Szyprowski wrote:
> Improve readability of the sg_dma_len assignment in the P2PDMA cases by
> removing duplicated code, which was a direct result of the d0d08f4bd7f6
> ("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings")
> fix. No functional change.
> 
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  kernel/dma/direct.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leon@kernel.org>