EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF

[PATCH v2] EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF

Posted by Faiyaz Mohammed 1 week, 5 days ago

On Shikra, the DDR System Firmware (DSF) configures ECC interrupt
routing before the kernel driver probes — it enables Tag/Data RAM
interrupts and programs error thresholds in the LLCC interrupt-enable
registers.

Set irq_configured in shikra_cfg so that qcom_llcc_edac_probe() skips
calling qcom_llcc_core_setup(), which would otherwise overwrite the
firmware-managed register state with redundant writes.

Signed-off-by: Faiyaz Mohammed <faiyaz.mohammed@oss.qualcomm.com>
---
Changes in v2:
- Dropped [1/2] "soc: qcom: llcc: Add configuration data for Shikra SoC"
  which was already merged via drivers-for-7.3.
- Resend as standalone single-patch series.

Link: https://lore.kernel.org/all/20260630-shikra-edac-v1-0-287b3233241a@oss.qualcomm.com/
---
 drivers/soc/qcom/llcc-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 22c8099cf6bb..733999867bbf 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -4595,6 +4595,7 @@ static const struct qcom_llcc_config shikra_cfg[] = {
 		.size		= ARRAY_SIZE(shikra_data),
 		.reg_offset	= llcc_v2_1_reg_offset,
 		.edac_reg_offset = &llcc_v2_1_edac_reg_offset,
+		.irq_configured = true,
 	},
 };
 

---
base-commit: 982af1cc6c964f143aac5c6afdba6380739577eb
change-id: 20260630-shikra-edac-b10540d0bea1

Best regards,
--  
Faiyaz Mohammed <faiyazm@qti.qualcomm.com>

Re: [PATCH v2] EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF

Posted by Bjorn Andersson 5 days, 4 hours ago

On Mon, 13 Jul 2026 15:28:52 +0530, Faiyaz Mohammed wrote:
> On Shikra, the DDR System Firmware (DSF) configures ECC interrupt
> routing before the kernel driver probes — it enables Tag/Data RAM
> interrupts and programs error thresholds in the LLCC interrupt-enable
> registers.
> 
> Set irq_configured in shikra_cfg so that qcom_llcc_edac_probe() skips
> calling qcom_llcc_core_setup(), which would otherwise overwrite the
> firmware-managed register state with redundant writes.
> 
> [...]

Applied, thanks!

[1/1] EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF
      commit: 43584144a46bccbe90482cd8eede9596d8fc47dc

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2] EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF

Posted by Mukesh Ojha 1 week, 1 day ago

On Mon, Jul 13, 2026 at 03:28:52PM +0530, Faiyaz Mohammed wrote:
> On Shikra, the DDR System Firmware (DSF) configures ECC interrupt
> routing before the kernel driver probes — it enables Tag/Data RAM
> interrupts and programs error thresholds in the LLCC interrupt-enable
> registers.
> 
> Set irq_configured in shikra_cfg so that qcom_llcc_edac_probe() skips
> calling qcom_llcc_core_setup(), which would otherwise overwrite the
> firmware-managed register state with redundant writes.
> 
> Signed-off-by: Faiyaz Mohammed <faiyaz.mohammed@oss.qualcomm.com>
> ---
> Changes in v2:
> - Dropped [1/2] "soc: qcom: llcc: Add configuration data for Shikra SoC"
>   which was already merged via drivers-for-7.3.
> - Resend as standalone single-patch series.
> 
> Link: https://lore.kernel.org/all/20260630-shikra-edac-v1-0-287b3233241a@oss.qualcomm.com/
> ---
>  drivers/soc/qcom/llcc-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 22c8099cf6bb..733999867bbf 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -4595,6 +4595,7 @@ static const struct qcom_llcc_config shikra_cfg[] = {
>  		.size		= ARRAY_SIZE(shikra_data),
>  		.reg_offset	= llcc_v2_1_reg_offset,
>  		.edac_reg_offset = &llcc_v2_1_edac_reg_offset,
> +		.irq_configured = true,

Not related to the change but somehow it feels like the name could be more meaningful 
something like irq_fw_configured, anyways..

Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
-- 
-Mukesh Ojha

Re: [PATCH v2] EDAC/qcom: Skip ECC interrupt setup on Shikra, pre-configured by DSF

Posted by Komal Bajaj 1 week, 4 days ago

On 7/13/2026 3:28 PM, Faiyaz Mohammed wrote:
> On Shikra, the DDR System Firmware (DSF) configures ECC interrupt
> routing before the kernel driver probes — it enables Tag/Data RAM
> interrupts and programs error thresholds in the LLCC interrupt-enable
> registers.
>
> Set irq_configured in shikra_cfg so that qcom_llcc_edac_probe() skips
> calling qcom_llcc_core_setup(), which would otherwise overwrite the
> firmware-managed register state with redundant writes.
>
> Signed-off-by: Faiyaz Mohammed <faiyaz.mohammed@oss.qualcomm.com>

Reviewed-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

--
Komal