efi/runtime-wrappers: fix linker warnings

[PATCH 0/2] efi/runtime-wrappers: fix linker warnings

Posted by Breno Leitao 1 week, 5 days ago

When I've submitted my last patchset titled "efi/runtime-wrappers: bound
the wait for EFI runtime service calls", I've got two reports

1) efi_rts_park_worker() loops forever and never returns, but wasn't
marked __noreturn, so objtool warns about the unreachable code after
the call.
https://lore.kernel.org/all/202607100848.iWPxdkhX-lkp@intel.com/

2) efi_runtime_lock_owner is optimised away under CONFIG_BUG=n, leaving a
dangling debug-info reference that breaks the link.
https://lore.kernel.org/all/202607100518.uMJJPDfP-lkp@intel.com/

Patch 1 fixes the objtool warning; patch 2 fixes the link error.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (2):
      efi/runtime-wrappers: mark efi_rts_park_worker() as __noreturn
      efi/runtime-wrappers: mark efi_runtime_lock_owner as __used

 drivers/firmware/efi/runtime-wrappers.c | 4 ++--
 include/linux/efi.h                     | 2 +-
 tools/objtool/noreturns.h               | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: cf790fdb851867532b9a0f88588dcce648dbffe9
change-id: 20260713-efi_fixes-b7193dd37bcf

Best regards,
--  
Breno Leitao <leitao@debian.org>

Re: [PATCH 0/2] efi/runtime-wrappers: fix linker warnings

Posted by Ard Biesheuvel 1 week, 4 days ago


On Mon, 13 Jul 2026, at 16:06, Breno Leitao wrote:
> When I've submitted my last patchset titled "efi/runtime-wrappers: bound
> the wait for EFI runtime service calls", I've got two reports
>
> 1) efi_rts_park_worker() loops forever and never returns, but wasn't
> marked __noreturn, so objtool warns about the unreachable code after
> the call.
> https://lore.kernel.org/all/202607100848.iWPxdkhX-lkp@intel.com/
>
> 2) efi_runtime_lock_owner is optimised away under CONFIG_BUG=n, leaving a
> dangling debug-info reference that breaks the link.
> https://lore.kernel.org/all/202607100518.uMJJPDfP-lkp@intel.com/
>
> Patch 1 fixes the objtool warning; patch 2 fixes the link error.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> Breno Leitao (2):
>       efi/runtime-wrappers: mark efi_rts_park_worker() as __noreturn
>       efi/runtime-wrappers: mark efi_runtime_lock_owner as __used
>

Queued up now, thanks.