staging: rtl8723bs: rename MACREG macros to snake_case

[PATCH] staging: rtl8723bs: rename MACREG macros to snake_case

Posted by Bohdan D. Marcus 1 week, 6 days ago

Fix checkpatch.pl warnings regarding CamelCase naming:
CHECK: Avoid CamelCase: <_Read_MACREG>
CHECK: Avoid CamelCase: <_Write_MACREG>

Rename _Read_MACREG and _Write_MACREG to read_macreg and
write_macreg respectively to comply with the Linux kernel
coding style.

Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c         | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_cmd.h      | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index b932670f5..f3b8a2bdf 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -11,8 +11,8 @@
 #include <linux/delay.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
-	{GEN_CMD_CODE(_Write_MACREG), NULL},
+	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
+	{GEN_CMD_CODE(write_macreg), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
 	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index f78aa0d7a..72403b96d 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -630,8 +630,8 @@ struct _cmd_callback {
 };
 
 enum {
-	GEN_CMD_CODE(_Read_MACREG),	/*0*/
-	GEN_CMD_CODE(_Write_MACREG),
+	GEN_CMD_CODE(read_macreg),	/*0*/
+	GEN_CMD_CODE(write_macreg),
 	GEN_CMD_CODE(_Read_BBREG),
 	GEN_CMD_CODE(_Write_BBREG),
 	GEN_CMD_CODE(_Read_RFREG),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index cb23c6939..59d9d35e4 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -675,7 +675,7 @@ void rtw_dummy_event_callback(struct adapter *adapter, u8 *pbuf);
 void rtw_fwdbg_event_callback(struct adapter *adapter, u8 *pbuf);
 
 enum {
-	GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
+	GEN_EVT_CODE(read_macreg) = 0, /*0*/
 	GEN_EVT_CODE(_Read_BBREG),
 	GEN_EVT_CODE(_Read_RFREG),
 	GEN_EVT_CODE(_Read_EEPROM),
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: rename MACREG macros to snake_case

Posted by Greg Kroah-Hartman 1 week, 1 day ago

On Sun, Jul 12, 2026 at 04:20:26PM +0300, Bohdan D. Marcus wrote:
> Fix checkpatch.pl warnings regarding CamelCase naming:
> CHECK: Avoid CamelCase: <_Read_MACREG>
> CHECK: Avoid CamelCase: <_Write_MACREG>
> 
> Rename _Read_MACREG and _Write_MACREG to read_macreg and
> write_macreg respectively to comply with the Linux kernel
> coding style.
> 
> Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c         | 4 ++--
>  drivers/staging/rtl8723bs/include/rtw_cmd.h      | 4 ++--
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b932670f5..f3b8a2bdf 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -11,8 +11,8 @@
>  #include <linux/delay.h>
>  
>  static struct _cmd_callback rtw_cmd_callback[] = {
> -	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> -	{GEN_CMD_CODE(_Write_MACREG), NULL},
> +	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
> +	{GEN_CMD_CODE(write_macreg), NULL},

Why just these 2?  Why not make a patch series to fix up all of these,
one patch per name?

thanks,
greg k-h