[PATCH v2] drm/panel: ilitek-ili9882t: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

Julian Braha posted 1 patch 1 week, 6 days ago
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] drm/panel: ilitek-ili9882t: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T
Posted by Julian Braha 1 week, 6 days ago
Currently, DRM_PANEL_ILITEK_ILI9882T selects DRM_DISPLAY_DSC_HELPER
without ensuring DRM_DISPLAY_HELPER is also enabled, causing an unmet
dependency and build failure.

Other similar options select DRM_DISPLAY_HELPER, let's do the same here.

This unmet dependency bug was found by kconfirm, a static analysis tool
for Kconfig.

Fixes: 68e28facbc8a ("drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: fixed commit blame and commit title
Link: https://lore.kernel.org/all/20260712001541.3AAC01F000E9@smtp.kernel.org/
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 06bfcef35a72..103f1d09a989 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -375,6 +375,7 @@ config DRM_PANEL_ILITEK_ILI9882T
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_HELPER
 	select DRM_DISPLAY_DSC_HELPER
 	help
 	  Say Y if you want to enable support for panels based on the
-- 
2.54.0
Re: [PATCH v2] drm/panel: ilitek-ili9882t: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T
Posted by Neil Armstrong 3 days, 8 hours ago
Hi,

On Sun, 12 Jul 2026 01:26:32 +0100, Julian Braha wrote:
> Currently, DRM_PANEL_ILITEK_ILI9882T selects DRM_DISPLAY_DSC_HELPER
> without ensuring DRM_DISPLAY_HELPER is also enabled, causing an unmet
> dependency and build failure.
> 
> Other similar options select DRM_DISPLAY_HELPER, let's do the same here.
> 
> This unmet dependency bug was found by kconfirm, a static analysis tool
> for Kconfig.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: ilitek-ili9882t: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/fc03f930bd9fd7c09617e41b1743e50ba659707c

-- 
Neil
Re: [PATCH v2] drm/panel: ilitek-ili9882t: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T
Posted by neil.armstrong@linaro.org 5 days, 9 hours ago
On 7/12/26 02:26, Julian Braha wrote:
> Currently, DRM_PANEL_ILITEK_ILI9882T selects DRM_DISPLAY_DSC_HELPER
> without ensuring DRM_DISPLAY_HELPER is also enabled, causing an unmet
> dependency and build failure.
> 
> Other similar options select DRM_DISPLAY_HELPER, let's do the same here.
> 
> This unmet dependency bug was found by kconfirm, a static analysis tool
> for Kconfig.
> 
> Fixes: 68e28facbc8a ("drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> Changes since v1: fixed commit blame and commit title
> Link: https://lore.kernel.org/all/20260712001541.3AAC01F000E9@smtp.kernel.org/
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 06bfcef35a72..103f1d09a989 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -375,6 +375,7 @@ config DRM_PANEL_ILITEK_ILI9882T
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>   	select DRM_DISPLAY_DSC_HELPER
>   	help
>   	  Say Y if you want to enable support for panels based on the

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil