[PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

Julian Braha posted 1 patch 1 week, 6 days ago
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A
Posted by Julian Braha 1 week, 6 days ago
Currently, DRM_PANEL_HIMAX_HX83121A selects DRM_DISPLAY_DSC_HELPER
without also ensuring DRM_DISPLAY_HELPER is enabled, causing an unmet
dependency:

WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
  Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
  Selected by [m]:
  - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
  - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]

Many other DRM_PANEL_* options select DRM_DISPLAY_HELPER when selecting
DRM_DISPLAY_DSC_HELPER, let's do the same here.

This unmet dependency bug was found by kconfirm, a static analysis tool
for Kconfig.

Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index cfbfb371bc67..06bfcef35a72 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -253,6 +253,7 @@ config DRM_PANEL_HIMAX_HX83121A
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_HELPER
 	select DRM_DISPLAY_DSC_HELPER
 	select DRM_KMS_HELPER
 	help
-- 
2.54.0
Re: [PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A
Posted by Neil Armstrong 3 days, 8 hours ago
Hi,

On Sun, 12 Jul 2026 00:42:30 +0100, Julian Braha wrote:
> Currently, DRM_PANEL_HIMAX_HX83121A selects DRM_DISPLAY_DSC_HELPER
> without also ensuring DRM_DISPLAY_HELPER is enabled, causing an unmet
> dependency:
> 
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
>   Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
>   Selected by [m]:
>   - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>   - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/aaa5be0258db1709e254b4150af5c2fa5518c548

-- 
Neil
Re: [PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A
Posted by neil.armstrong@linaro.org 5 days, 9 hours ago
On 7/12/26 01:42, Julian Braha wrote:
> Currently, DRM_PANEL_HIMAX_HX83121A selects DRM_DISPLAY_DSC_HELPER
> without also ensuring DRM_DISPLAY_HELPER is enabled, causing an unmet
> dependency:
> 
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
>    Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
>    Selected by [m]:
>    - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>    - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
> 
> Many other DRM_PANEL_* options select DRM_DISPLAY_HELPER when selecting
> DRM_DISPLAY_DSC_HELPER, let's do the same here.
> 
> This unmet dependency bug was found by kconfirm, a static analysis tool
> for Kconfig.
> 
> Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cfbfb371bc67..06bfcef35a72 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -253,6 +253,7 @@ config DRM_PANEL_HIMAX_HX83121A
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>   	select DRM_DISPLAY_DSC_HELPER
>   	select DRM_KMS_HELPER
>   	help

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil