[PATCH] memory: jz4780-nemc: Use dev_err_probe() for clock error

Miles Krause via B4 Relay posted 1 patch 1 week, 6 days ago
drivers/memory/jz4780-nemc.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
[PATCH] memory: jz4780-nemc: Use dev_err_probe() for clock error
Posted by Miles Krause via B4 Relay 1 week, 6 days ago
From: Miles Krause <mileskrause5200@gmail.com>

Use dev_err_probe() to simplify clock acquisition error handling and
avoid logging probe deferral as an error.

No functional change.

Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Built with:

make O=out W=1 drivers/memory/jz4780-nemc.o

To: Paul Cercueil <paul@crapouillou.net>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/memory/jz4780-nemc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c
index 1a8161514d03..1bf17057cbf5 100644
--- a/drivers/memory/jz4780-nemc.c
+++ b/drivers/memory/jz4780-nemc.c
@@ -313,10 +313,9 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
 	writel(0, nemc->base + NEMC_NFCSR);
 
 	nemc->clk = devm_clk_get(dev, NULL);
-	if (IS_ERR(nemc->clk)) {
-		dev_err(dev, "failed to get clock\n");
-		return PTR_ERR(nemc->clk);
-	}
+	if (IS_ERR(nemc->clk))
+		return dev_err_probe(dev, PTR_ERR(nemc->clk),
+				     "failed to get clock\n");
 
 	ret = clk_prepare_enable(nemc->clk);
 	if (ret) {

---
base-commit: 8111c7f3723f414b7f655a3880775cbbd0e9de8e
change-id: 20260711-jz4780-nemc-dev-err-probe-ddc559b8bba1

Best regards,
--  
Miles Krause <mileskrause5200@gmail.com>
Re: [PATCH] memory: jz4780-nemc: Use dev_err_probe() for clock error
Posted by Krzysztof Kozlowski 5 hours ago
On Sat, 11 Jul 2026 22:56:14 -0400, Miles Krause wrote:
> Use dev_err_probe() to simplify clock acquisition error handling and
> avoid logging probe deferral as an error.
> 
> No functional change.

Applied, thanks!

[1/1] memory: jz4780-nemc: Use dev_err_probe() for clock error
      https://git.kernel.org/krzk/linux-mem-ctrl/c/96aa6902ff2bf81b9b8e0fa228494595dc2374a9

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>