arm64: dts: qcom: milos: Add reset for sdhc_2

[PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2

Posted by Luca Weiss 2 weeks, 1 day ago

Add the missing reset (BCR) for sdhc_2.

Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
index 8c9232988953..262fa8801256 100644
--- a/arch/arm64/boot/dts/qcom/milos.dtsi
+++ b/arch/arm64/boot/dts/qcom/milos.dtsi
@@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 
 			iommus = <&apps_smmu 0x540 0>;
 
+			resets = <&gcc GCC_SDCC2_BCR>;
+
 			bus-width = <4>;
 
 			qcom,dll-config = <0x0007442c>;

---
base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8

Best regards,
--  
Luca Weiss <luca.weiss@fairphone.com>

Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2

Posted by Bjorn Andersson 1 week, 6 days ago

On Fri, 10 Jul 2026 11:53:57 +0200, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: milos: Add reset for sdhc_2
      commit: ab07ee0b1b29ce2672ae3b9ca208033c3ada12c2

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2

Posted by Bjorn Andersson 1 week, 6 days ago

On Fri, Jul 10, 2026 at 11:53:57AM +0200, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.

Don't be afraid of tell the world why a particular change is needed...

Regards,
Bjorn

> 
> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 8c9232988953..262fa8801256 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>  
>  			iommus = <&apps_smmu 0x540 0>;
>  
> +			resets = <&gcc GCC_SDCC2_BCR>;
> +
>  			bus-width = <4>;
>  
>  			qcom,dll-config = <0x0007442c>;
> 
> ---
> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
> change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8
> 
> Best regards,
> --  
> Luca Weiss <luca.weiss@fairphone.com>
>

Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2

Posted by Luca Weiss 1 week, 5 days ago

On Sun Jul 12, 2026 at 5:05 PM CEST, Bjorn Andersson wrote:
> On Fri, Jul 10, 2026 at 11:53:57AM +0200, Luca Weiss wrote:
>> Add the missing reset (BCR) for sdhc_2.
>
> Don't be afraid of tell the world why a particular change is needed...

I didn't see any issue without this on my device, but usually the SDCC2
BCR is referenced in the devicetree so that the driver can reset the
controller.

No other special reasons I didn't mention :)

Thanks for applying!

Regards
Luca

>
> Regards,
> Bjorn
>
>> 
>> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
>> index 8c9232988953..262fa8801256 100644
>> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
>> @@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>>  
>>  			iommus = <&apps_smmu 0x540 0>;
>>  
>> +			resets = <&gcc GCC_SDCC2_BCR>;
>> +
>>  			bus-width = <4>;
>>  
>>  			qcom,dll-config = <0x0007442c>;
>> 
>> ---
>> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
>> change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8
>> 
>> Best regards,
>> --  
>> Luca Weiss <luca.weiss@fairphone.com>
>>

Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2

Posted by Konrad Dybcio 2 weeks, 1 day ago

On 7/10/26 11:53 AM, Luca Weiss wrote:
> Add the missing reset (BCR) for sdhc_2.
> 
> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad