[PATCH] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link

Biren Pandya posted 1 patch 2 weeks, 3 days ago
There is a newer version of this series
drivers/media/v4l2-core/v4l2-fwnode.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link
Posted by Biren Pandya 2 weeks, 3 days ago
In v4l2_fwnode_parse_link(), the remote endpoint fwnode reference is
acquired using fwnode_graph_get_remote_endpoint(). This reference is
properly released in the error paths, but it is leaked on the success
path. Add the missing fwnode_handle_put() before returning 0 to prevent
the reference leak.

Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties")
Cc: stable@vger.kernel.org
Signed-off-by: Biren Pandya <birenpandya@gmail.com>
---
 drivers/media/v4l2-core/v4l2-fwnode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index 77f3298821b5c..93ef83c591ef2 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -633,6 +633,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode,
 	if (!link->remote_node)
 		goto err_put_remote_endpoint;
 
+	fwnode_handle_put(fwnode);
 	return 0;
 
 err_put_remote_endpoint:
-- 
2.50.1 (Apple Git-155)