Hi Christian,
Can you pick up these miscellaneous AFS fixes, please?
(1) Fix the CB.InitCallBackState3 service handler to handle an unknown
server (server pointer is NULL).
(2) Fix the clobbering of the default error code in
afs_extract_vl_addrs().
(3) Fix a NULL pointer in a trace point in afs_get_tree().
(4) Fix double netfs_inode initialisation in afs_root_iget().
(5) Fix setting of AS_RELEASE_ALWAYS for symlinks (and mountpoints) as
there's no release_folio function provided. The pagecache isn't used
by afs for symlinks and directories.
(6) Fix the order of inode init to avoid clobbering
NETFS_ICTX_SINGLE_NO_UPLOAD set on directories.
(7) Fix the release of op->more_files to Use kvfree().
(8) Fix erroneous seq |= 1 in volume lookup loop.
(9) Drop for duplicate server records when parsing DNS reply into the VL
server list (this is not strictly a bug fix, so could be punted to the
merge window).
(10) Fix malfunction in bulk lookup due to change in dir_emit() API added
to mask off DT_* flags for overlayfs on fuse.
(11) Fix misplaced inc of net->cells_outstanding causing netns destruction
hang.
(12) Fix reinitialisation of afs_vnode::lock_work. Not reinitialising it
after allocation seems to upset DEBUG_OBJECTS despite there being an
slab init-once handler provided.
(13) Fix callback service message parsers to pass through -EAGAIN when
insufficient data yet received.
(14) Switch to using scoped_seqlock_read() in volume lookup loop as a
follow up to (6).
(15) Fix leak of a volume we failed to get because its refcount had hit 0.
(16) Fix missing NULL pointer check in afs_break_some_callbacks().
(17) Fix leak of empty new vllist in afs_update_cell().
(18) Fix modifications of net->cells_dyn_ino to use locking; this requires
the use of preallocation as the allocation has to be done under
spinlock.
(19) Fix insertion into net->cells_dyn_ino to only add a new cell into the
IDR only after we've checked it's not a duplicate.
(20) Fix afs_insert_volume_into_cell() to set AFS_VOLUME_RM_TREE on the
old volume, not the new.
(21) Fix afs_extract_vlserver_list() to limit the string displayed in the
debug statement.
The patches can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes
Thanks,
David
Changes
=======
ver #4)
- Addressed some Sashiko comments[3]:
- Fixed param name on afs_lookup_filldir() and afs_lookup_one_filldir().
- Fixed the cells_dyn_ino locking patch to use cells_lock rather than
making a separate spinlock as dir_emit() must be callable thereunder.
- Added another cells_dyn_ino patch to insert a new cell into the IDR
only after we've checked it isn't a duplicate.
ver #3)
- Relabelled the patch that switched to using scoped_seqlock_read().
- Moved a bit from scoped_seqlock_read() patch to the preceding patch that
had got committed to the wrong patch.
- Merged the two AS_RELEASE_ALWAYS patches.
- Moved patch to remove double-init from afs_root_iget() before
AS_RELEASE_ALWAYS patch.
- Moved the patch to check for a NULL pointer in afs_break_some_callbacks()
before the patch to lookup the volume that might then return NULL.
- Addressed some Sashiko comments[2]:
- Made the ->lock_work reinit patch also flush the work when evicting an
inode.
- Made the afs_break_some_callbacks() NULL check patch drop the RCU lock
and clear the count if the server is unknown.
- Added some new fix patches.
ver #2)
- Added patches to fix issues raised by Sashiko[1]
[1] https://sashiko.dev/#/patchset/20260609081738.770127-1-dhowells%40re
[2] https://sashiko.dev/#/patchset/20260618074903.2374756-1-dhowells%40redhat.com
[3] https://sashiko.dev/#/patchset/20260618155141.2513212-1-dhowells%40redhat.com
Dan Carpenter (1):
afs: Fix error code in afs_extract_vl_addrs()
David Howells (15):
afs: Fix double netfs initialisation in afs_root_iget()
afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints
afs: Fix directory inode initialisation order
afs: Fix bulk lookup malfunction due to change in dir_emit() API
afs: Fix misplaced inc of net->cells_outstanding
afs: Fix reinitialisation of the inode, in particular ->lock_work
afs: Fix callback service message parsers to pass through -EAGAIN
afs: Use scoped_seqlock_read() rather than manually doing seqlock
stuff
afs: Fix missing NULL pointer check in afs_break_some_callbacks()
afs: Fix leak of ungot volume
afs: Fix vllist leak
afs: Fix lack of locking around modifications of net->cells_dyn_ino
afs: Fix premature cell exposure through /afs
afs: Fix the volume AFS_VOLUME_RM_TREE is set on
afs: Fix unchecked-length string display in debug statement
Li RongQing (1):
afs: Remove erroneous seq |= 1 in volume lookup loop
Matvey Kovalev (1):
afs: fix NULL pointer dereference in afs_get_tree()
Nan Li (1):
afs: handle CB.InitCallBackState3 requests without a server record
Yuto Ohnuki (1):
afs: check for duplicate servers in VL server list
Zilin Guan (1):
afs: use kvfree() to free memory allocated by kvcalloc()
fs/afs/callback.c | 17 +++++++----------
fs/afs/cell.c | 27 +++++++++++++++++++++------
fs/afs/cmservice.c | 7 +++++--
fs/afs/dir.c | 40 +++++++++++++++++++++++++---------------
fs/afs/dynroot.c | 2 +-
fs/afs/fs_operation.c | 2 +-
fs/afs/inode.c | 15 +++++++--------
fs/afs/internal.h | 3 +--
fs/afs/super.c | 5 +++--
fs/afs/vl_list.c | 24 +++++++++++++++++++++---
fs/afs/volume.c | 2 +-
11 files changed, 93 insertions(+), 51 deletions(-)