[v4] dmaengine: tegra210-adma: use platform to ioremap

[PATCHv4] dmaengine: tegra210-adma: use platform to ioremap

Posted by Rosen Penev 1 week ago

Simpler to call devm_platform_ioremap_resource() as it returns multiple
error messages for whichever part fails.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v4: rebase and reword commit message
 v3: change subject
 v2: reword commit message
 drivers/dma/tegra210-adma.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index ceaee1e33e68..21a381d022cf 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
 		}
 	} else {
 		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return dev_err_probe(&pdev->dev, -ENODEV,
-					     "failed to get memory resource\n");
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);

 		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
 	}
--
2.54.0

Re: [PATCHv4] dmaengine: tegra210-adma: use platform to ioremap

Posted by Jon Hunter 6 days, 20 hours ago

On 09/06/2026 22:25, Rosen Penev wrote:
> Simpler to call devm_platform_ioremap_resource() as it returns multiple
> error messages for whichever part fails.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>   v4: rebase and reword commit message
>   v3: change subject
>   v2: reword commit message
>   drivers/dma/tegra210-adma.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index ceaee1e33e68..21a381d022cf 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
>   		}
>   	} else {
>   		/* If no 'page' property found, then reg DT binding would be legacy */
> -		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		if (res_base) {
> -			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
> -			if (IS_ERR(tdma->base_addr))
> -				return PTR_ERR(tdma->base_addr);
> -		} else {
> -			return dev_err_probe(&pdev->dev, -ENODEV,
> -					     "failed to get memory resource\n");
> -		}
> +		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
> +		if (IS_ERR(tdma->base_addr))
> +			return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't 
drop this.

Jon

-- 
nvpublic

Re: [PATCHv4] dmaengine: tegra210-adma: use platform to ioremap

Posted by Frank Li 1 week ago

On Tue, Jun 09, 2026 at 02:25:31PM -0700, Rosen Penev wrote:

Nit: subject
dmaengine: tegra210-adma: use devm_platform_ioremap_resource()

> Simpler to call devm_platform_ioremap_resource() as it returns multiple
> error messages for whichever part fails.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  v4: rebase and reword commit message
>  v3: change subject
>  v2: reword commit message
>  drivers/dma/tegra210-adma.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index ceaee1e33e68..21a381d022cf 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
>  		}
>  	} else {
>  		/* If no 'page' property found, then reg DT binding would be legacy */
> -		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		if (res_base) {
> -			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
> -			if (IS_ERR(tdma->base_addr))
> -				return PTR_ERR(tdma->base_addr);
> -		} else {
> -			return dev_err_probe(&pdev->dev, -ENODEV,
> -					     "failed to get memory resource\n");
> -		}
> +		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
> +		if (IS_ERR(tdma->base_addr))
> +			return PTR_ERR(tdma->base_addr);
>
>  		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
>  	}
> --
> 2.54.0
>