[v2] ipv4: igmp: annotate diagnostic procfs data races

[PATCH net-next v2 0/2] ipv4: igmp: annotate diagnostic procfs data races

Yuyang Huang posted 2 patches 3 days, 4 hours ago

Diff against v1
Download series mbox

net/ipv4/igmp.c | 35 ++++++++++++++++++++---------------
1 file changed, 20 insertions(+), 15 deletions(-)

Expand all Fold all

[PATCH net-next v2 0/2] ipv4: igmp: annotate diagnostic procfs data races

Posted by Yuyang Huang 3 days, 4 hours ago

This patch series addresses several unannotated data races between lockless
RCU-protected diagnostic reads in /proc/net/igmp (igmp_mc_seq_show())
and concurrent writes in serialized paths (RTNL and group spinlocks).

Following the precedent in commit 061c0aa740d5 ("ipv4: igmp: annotate
data-races around im->users"), we annotate these intentional data races
using READ_ONCE() and WRITE_ONCE() macros.

- Patch 1 annotates races around `in_dev->mc_count` (interface-level joins).
- Patch 2 annotates races around active timer-related state tracking fields
  (`tm_running`, `reporter`, `expires`) on individual multicast groups.

Changes in v2:
  - Remove "Fixes:" tag from the commit messages.
  - Fix reverse Christmas tree variable declaration order in igmp_mc_seq_show().

Yuyang Huang (2):
  ipv4: igmp: annotate data-races around in_dev->mc_count
  ipv4: igmp: annotate data-races around timer-related fields

 net/ipv4/igmp.c | 35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)

-- 
2.54.0.1032.g2f8565e1d1-goog