.../ethernet/stmicro/stmmac/dwxgmac2_core.c | 28 +++++++++++-------- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 27 ++++++++++++++++++ 2 files changed, 43 insertions(+), 12 deletions(-)
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
This series fixes three bugs in the stmmac L3/L4 TC flower filter
implementation for the XGMAC2 core. All three patches target net.
The L3/L4 filter match count statistics patch (originally patch 4/4)
has been split out and will be sent separately against net-next per
Andrew Lunn's review of v1.
Patch 1 fixes a register corruption bug in the L4 filter port configuration.
The XGMAC_L4_ADDR register holds both source and destination port match
values in a single register. The original code overwrites the entire register
when setting either field, silently erasing the other. This is fixed by
using a read-modify-write sequence.
Patch 2 fixes the basic flow match parser to properly reject unsupported
offload requests with -EOPNOTSUPP instead of silently accepting them.
Unsupported cases include partial protocol masks, non-IPv4 network proto,
and non-TCP/UDP transport proto.
Patch 3 fixes a stale action bug on filter deletion. When a filter entry
with a drop action is deleted, the action field was not reset, causing
it to persist and potentially affect subsequent filter configurations.
All three patches fix the original L3/L4 filter implementation introduced in
425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower").
Changes in v2:
- Split patch 4/4 (ethtool stats) out to net-next per Andrew Lunn's review
Nazim Amirul (3):
net: stmmac: xgmac: fix l4 filter port overwrite on register update
net: stmmac: fix l3l4 filter rejecting unsupported offload requests
net: stmmac: reset residual action in L3L4 filters on delete
.../ethernet/stmicro/stmmac/dwxgmac2_core.c | 28 +++++++++++--------
.../net/ethernet/stmicro/stmmac/stmmac_tc.c | 27 ++++++++++++++++++
2 files changed, 43 insertions(+), 12 deletions(-)
--
2.43.7
On Thu, 4 Jun 2026 01:33:47 -0700 muhammad.nazim.amirul.nazle.asmade@altera.com wrote: > Changes in v2: > - Split patch 4/4 (ethtool stats) out to net-next per Andrew Lunn's review Now this posting has 2 cover letters, patchwork latched onto first one which describes 4 patches, and it's going to wait for patch 4 before kicking off the CI. Please wait a day and repost again with this fixed :/
On 4/6/2026 11:00 pm, Jakub Kicinski wrote: > On Thu, 4 Jun 2026 01:33:47 -0700 > muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >> Changes in v2: >> - Split patch 4/4 (ethtool stats) out to net-next per Andrew Lunn's review > > Now this posting has 2 cover letters, patchwork latched onto first one > which describes 4 patches, and it's going to wait for patch 4 before > kicking off the CI. Please wait a day and repost again with this fixed > :/ reposted :)
© 2016 - 2026 Red Hat, Inc.