drivers/iio/accel/stk8312.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
From: Miao Li <limiao@kylinos.cn>
Update the list of included headers in stk8312.c using
Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
and add missing headers such as array_size.h, bits.h,
dev_printk.h, etc.
Meanwhile, sort these headers in alphabetical order.
Signed-off-by: Miao Li <limiao@kylinos.cn>
---
drivers/iio/accel/stk8312.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
index f31c6ab3392d..959dfdf61db4 100644
--- a/drivers/iio/accel/stk8312.c
+++ b/drivers/iio/accel/stk8312.c
@@ -7,12 +7,20 @@
* IIO driver for STK8312; 7-bit I2C address: 0x3D.
*/
+#include <linux/array_size.h>
+#include <linux/bits.h>
+#include <linux/delay.h>
+#include <linux/dev_printk.h>
+#include <linux/errno.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
-#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/delay.h>
+#include <linux/mod_devicetable.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
+#include <linux/sysfs.h>
#include <linux/types.h>
+
#include <linux/iio/buffer.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
--
2.25.1
On Thu, 4 Jun 2026 at 09:11, Miao Li <limiao870622@163.com> wrote: > > From: Miao Li <limiao@kylinos.cn> > > Update the list of included headers in stk8312.c using > Include-What-You-Use (IWYU) tool, mainly to remove kernel.h > and add missing headers such as array_size.h, bits.h, > dev_printk.h, etc. > > Meanwhile, sort these headers in alphabetical order. > > Signed-off-by: Miao Li <limiao@kylinos.cn> > --- No need to resend IMO, however you're missing a changelog. Additionally, wrap the body of the commit message to 72 characters next time, per guidelines. -- Kind regards CJD
On Thu, Jun 04, 2026 at 03:00:53PM +0800, Miao Li wrote: > Update the list of included headers in stk8312.c using > Include-What-You-Use (IWYU) tool, mainly to remove kernel.h > and add missing headers such as array_size.h, bits.h, > dev_printk.h, etc. > Meanwhile, sort these headers in alphabetical order. Usually we do sort in a separate change, but here it's just about a single unordered item, so I believe it's completely fine to combine (in _this_ case). Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.