[PATCH] media: qcom: iris: initialize managed OPP pointer

Hungyu Lin posted 1 patch 4 days, 8 hours ago
drivers/media/platform/qcom/iris/iris_resources.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] media: qcom: iris: initialize managed OPP pointer
Posted by Hungyu Lin 4 days, 8 hours ago
Initialize the __free(put_opp) managed OPP pointer to NULL.

This ensures the cleanup handler always sees a defined value and
avoids leaving the managed pointer uninitialized before assignment.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/media/platform/qcom/iris/iris_resources.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
index 773f6548370a..6b22f5cc88ca 100644
--- a/drivers/media/platform/qcom/iris/iris_resources.c
+++ b/drivers/media/platform/qcom/iris/iris_resources.c
@@ -61,7 +61,7 @@ int iris_unset_icc_bw(struct iris_core *core)
 
 int iris_opp_set_rate(struct device *dev, unsigned long freq)
 {
-	struct dev_pm_opp *opp __free(put_opp);
+	struct dev_pm_opp *opp __free(put_opp) = NULL;
 
 	opp = devfreq_recommended_opp(dev, &freq, 0);
 	if (IS_ERR(opp))
-- 
2.34.1
Re: [PATCH] media: qcom: iris: initialize managed OPP pointer
Posted by Dmitry Baryshkov 11 hours ago
On Thu, Jun 04, 2026 at 12:04:14AM +0000, Hungyu Lin wrote:
> Initialize the __free(put_opp) managed OPP pointer to NULL.
> 
> This ensures the cleanup handler always sees a defined value and
> avoids leaving the managed pointer uninitialized before assignment.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/media/platform/qcom/iris/iris_resources.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
> index 773f6548370a..6b22f5cc88ca 100644
> --- a/drivers/media/platform/qcom/iris/iris_resources.c
> +++ b/drivers/media/platform/qcom/iris/iris_resources.c
> @@ -61,7 +61,7 @@ int iris_unset_icc_bw(struct iris_core *core)
>  
>  int iris_opp_set_rate(struct device *dev, unsigned long freq)
>  {
> -	struct dev_pm_opp *opp __free(put_opp);
> +	struct dev_pm_opp *opp __free(put_opp) = NULL;
>  
>  	opp = devfreq_recommended_opp(dev, &freq, 0);

No. Rather squash these two lines.

>  	if (IS_ERR(opp))
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry