[PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532

Kim Seer Paller posted 3 patches 4 days, 2 hours ago
Documentation/ABI/testing/sysfs-bus-iio            |   1 +
.../devicetree/bindings/iio/dac/adi,ad3530r.yaml   |  16 +-
drivers/iio/dac/Kconfig                            |   4 +-
drivers/iio/dac/ad3530r.c                          | 315 +++++++++++++++++++--
4 files changed, 302 insertions(+), 34 deletions(-)
[PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532
Posted by Kim Seer Paller 4 days, 2 hours ago
This series adds support for the AD3532R/AD3532, a 16-channel, 16-bit
voltage output DAC, to the existing ad3530r driver.

The AD3532R uses a dual-bank register architecture (bank 0 at 0x1000
for channels 0-7, bank 1 at 0x3000 for channels 8-15), which required
refactoring the register access paths. A table-driven register bank
approach is introduced where per-chip register address arrays in
chip_info are iterated by helper functions, replacing the single-register
setup calls for existing variants and scaling naturally to the AD3532R's
dual-bank layout.

The series also adds AD3532R-specific powerdown modes (1kohm_to_gnd,
10kohm_to_gnd, three_state) and a new ABI entry for the 10kohm_to_gnd
powerdown mode.

Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
---
Kim Seer Paller (3):
      iio: ABI: add DAC 10kohm_to_gnd powerdown mode
      dt-bindings: iio: dac: add support for AD3532R/AD3532
      iio: dac: ad3530r: Add support for AD3532R/AD3532

 Documentation/ABI/testing/sysfs-bus-iio            |   1 +
 .../devicetree/bindings/iio/dac/adi,ad3530r.yaml   |  16 +-
 drivers/iio/dac/Kconfig                            |   4 +-
 drivers/iio/dac/ad3530r.c                          | 315 +++++++++++++++++++--
 4 files changed, 302 insertions(+), 34 deletions(-)
---
base-commit: ae696dfa47c30016cd429b9db5e70b259b8f509e
change-id: 20260604-iio-ad3532r-support-759067e904e1

Best regards,
--  
Kim Seer Paller <kimseer.paller@analog.com>
Re: [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532
Posted by Andy Shevchenko 4 days ago
On Thu, Jun 04, 2026 at 03:13:42PM +0800, Kim Seer Paller wrote:
> This series adds support for the AD3532R/AD3532, a 16-channel, 16-bit
> voltage output DAC, to the existing ad3530r driver.
> 
> The AD3532R uses a dual-bank register architecture (bank 0 at 0x1000
> for channels 0-7, bank 1 at 0x3000 for channels 8-15), which required
> refactoring the register access paths. A table-driven register bank
> approach is introduced where per-chip register address arrays in
> chip_info are iterated by helper functions, replacing the single-register
> setup calls for existing variants and scaling naturally to the AD3532R's
> dual-bank layout.
> 
> The series also adds AD3532R-specific powerdown modes (1kohm_to_gnd,
> 10kohm_to_gnd, three_state) and a new ABI entry for the 10kohm_to_gnd
> powerdown mode.

This cover letter misses two required things:
- why do we need a brand new driver (provide an explanation)?
- where to get the datasheet (provide a link)?

Just reply to this email and if new version is required do not forget
to add it to the cover letter.

-- 
With Best Regards,
Andy Shevchenko