drivers/of: fdt: Make ibm,phandle logic only happen on pseries

[PATCH] drivers/of: fdt: Make ibm,phandle logic only happen on pseries

Posted by Daniel Palmer 4 days, 16 hours ago

The "ibm,phandle" thing only seems to be needed on pseries
machines but everyone gets it so they get a string and a little
bit of useless code.

In __of_attach_node() the pseries specific part uses
IS_ENABLED(CONFIG_PPC_PSERIES) so do that here too.

Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
 drivers/of/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 82f7327c59ea..2260a7c0c494 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -145,7 +145,7 @@ static void populate_properties(const void *blob,
 		 * used in pSeries dynamic device tree
 		 * stuff
 		 */
-		if (!strcmp(pname, "ibm,phandle"))
+		if (IS_ENABLED(CONFIG_PPC_PSERIES) && !strcmp(pname, "ibm,phandle"))
 			np->phandle = be32_to_cpup(val);
 
 		pp->name   = (char *)pname;
-- 
2.53.0

Re: [PATCH] drivers/of: fdt: Make ibm,phandle logic only happen on pseries

Posted by Rob Herring (Arm) 4 days, 9 hours ago

On Thu, 04 Jun 2026 00:18:09 +0900, Daniel Palmer wrote:
> The "ibm,phandle" thing only seems to be needed on pseries
> machines but everyone gets it so they get a string and a little
> bit of useless code.
> 
> In __of_attach_node() the pseries specific part uses
> IS_ENABLED(CONFIG_PPC_PSERIES) so do that here too.
> 
> Signed-off-by: Daniel Palmer <daniel@thingy.jp>
> ---
>  drivers/of/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!