b43legacy: remove redundant mask bit set

[PATCH] b43legacy: remove redundant mask bit set

Posted by Jeeva Anandh 4 days, 17 hours ago

mask is initialized to 0x0000001F, which already contains
the 0x0010 bit. Therefore the conditional OR operation is
redundant and can be removed.

Signed-off-by: Jeeva Anandh <anandhjeeva215@gmail.com>
---
 drivers/net/wireless/broadcom/b43legacy/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
index 6b3e0b2bbca7..d32bffa6f009 100644
--- a/drivers/net/wireless/broadcom/b43legacy/main.c
+++ b/drivers/net/wireless/broadcom/b43legacy/main.c
@@ -1904,8 +1904,6 @@ static int b43legacy_gpio_init(struct b43legacy_wldev *dev)
 		mask |= 0x0200;
 		set |= 0x0200;
 	}
-	if (dev->dev->id.revision >= 2)
-		mask  |= 0x0010; /* FIXME: This is redundant. */
 
 #ifdef CONFIG_SSB_DRIVER_PCICORE
 	pcidev = bus->pcicore.dev;
-- 
2.43.0

Re: [PATCH] b43legacy: remove redundant mask bit set

Posted by Michael Büsch 4 days, 14 hours ago

On Wed,  3 Jun 2026 12:53:31 +0000
Jeeva Anandh <anandhjeeva215@gmail.com> wrote:

> mask is initialized to 0x0000001F, which already contains
> the 0x0010 bit. Therefore the conditional OR operation is
> redundant and can be removed.
> 
> Signed-off-by: Jeeva Anandh <anandhjeeva215@gmail.com>
> ---
>  drivers/net/wireless/broadcom/b43legacy/main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
> index 6b3e0b2bbca7..d32bffa6f009 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> @@ -1904,8 +1904,6 @@ static int b43legacy_gpio_init(struct b43legacy_wldev *dev)
>  		mask |= 0x0200;
>  		set |= 0x0200;
>  	}
> -	if (dev->dev->id.revision >= 2)
> -		mask  |= 0x0010; /* FIXME: This is redundant. */
>  
>  #ifdef CONFIG_SSB_DRIVER_PCICORE
>  	pcidev = bus->pcicore.dev;

No, please don't just remove these things.
There is a FIXME in the comment, because the author already noticed that this
was strange and that there probably is an unknown reason for this.
Just removing this FIXME without clarifying the underlying reason
does not improve the code quality.

-- 
Michael Büsch
https://bues.ch/