[PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

Thorsten Blum posted 1 patch 5 days, 5 hours ago
drivers/gpu/drm/bridge/sii902x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
Posted by Thorsten Blum 5 days, 5 hours ago
Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/gpu/drm/bridge/sii902x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 12497f5ce4ff..0cc738e2dd63 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1158,9 +1158,7 @@ static int sii902x_probe(struct i2c_client *client)
 	static const char * const supplies[] = {"iovcc", "cvcc12"};
 	int ret;
 
-	ret = i2c_check_functionality(client->adapter,
-				      I2C_FUNC_SMBUS_BYTE_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
 		dev_err(dev, "I2C adapter not suitable\n");
 		return -EIO;
 	}
Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
Posted by Luca Ceresoli 4 days, 14 hours ago
On Wed Jun 3, 2026 at 12:31 AM CEST, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com