drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
criu_checkpoint_events() allocates the ev_privs[] array, sized by the
runtime count returned from kfd_get_num_events(), using the open-coded
kvzalloc(n * sizeof(*p), ...) form. Switch to kvcalloc(), which
carries the same zero-on-allocation semantics and adds the standard
size_mul overflow check on the n * sizeof multiplication.
No functional change.
Signed-off-by: William Theesfeld <william@theesfeld.net>
---
drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_events.c
index 44150a71f..9739214e2 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_events.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_events.c
@@ -543,7 +543,7 @@ int kfd_criu_checkpoint_events(struct kfd_process *p,
if (!num_events)
return 0;
- ev_privs = kvzalloc(num_events * sizeof(*ev_privs), GFP_KERNEL);
+ ev_privs = kvcalloc(num_events, sizeof(*ev_privs), GFP_KERNEL);
if (!ev_privs)
return -ENOMEM;
--
2.54.0
On 2026-06-01 15:55, William Theesfeld wrote: > [You don't often get email from william@theesfeld.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > criu_checkpoint_events() allocates the ev_privs[] array, sized by the > runtime count returned from kfd_get_num_events(), using the open-coded > kvzalloc(n * sizeof(*p), ...) form. Switch to kvcalloc(), which > carries the same zero-on-allocation semantics and adds the standard > size_mul overflow check on the n * sizeof multiplication. > > No functional change. > > Signed-off-by: William Theesfeld <william@theesfeld.net> Reviewed-by: Felix Kuehling <felix.kuehling@amd.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_events.c > index 44150a71f..9739214e2 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_events.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_events.c > @@ -543,7 +543,7 @@ int kfd_criu_checkpoint_events(struct kfd_process *p, > if (!num_events) > return 0; > > - ev_privs = kvzalloc(num_events * sizeof(*ev_privs), GFP_KERNEL); > + ev_privs = kvcalloc(num_events, sizeof(*ev_privs), GFP_KERNEL); > if (!ev_privs) > return -ENOMEM; > > -- > 2.54.0 >
© 2016 - 2026 Red Hat, Inc.