[PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm

Rosen Penev posted 1 patch 6 days, 9 hours ago
drivers/ata/pata_ep93xx.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm
Posted by Rosen Penev 6 days, 9 hours ago
The inline assembly in ep93xx_pata_delay() uses a "subs" instruction
which modifies the ARM condition code flags. Add a "cc" clobber so
the compiler knows the flags are altered. Without it, the compiler may
reorder flag-dependent instructions across the asm block when the
function is inlined, potentially causing incorrect control flow.

Assisted-by: Opencode:Big-Pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/ata/pata_ep93xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
index aa6f8172925d..838cab54d58a 100644
--- a/drivers/ata/pata_ep93xx.c
+++ b/drivers/ata/pata_ep93xx.c
@@ -211,6 +211,7 @@ static void ep93xx_pata_delay(unsigned long count)
 		"bge 0b\n"
 		: "=r" (count)
 		: "0" (count)
+		: "cc"
 	);
 }
 
-- 
2.54.0