[v1] MAINTAINERS: add entry for SpacemiT reset controller driver

[PATCH] MAINTAINERS: add entry for SpacemiT reset controller driver

Posted by Guodong Xu 6 days, 1 hour ago

The SpacemiT reset controller driver under drivers/reset/spacemit/
(common code plus the K1 and K3 SoC instances) and its reset-ID header
have no dedicated MAINTAINERS entry; today they fall only under the
broad drivers/reset/ entry of the reset subsystem and the N:/K:
catch-all of the RISC-V SpacemiT SoC umbrella.

Add a dedicated entry and list myself as maintainer. I introduced the
drivers/reset/spacemit/ subdirectory, moved and refactored the existing
K1 reset support (originally written by Alex Elder) into it, and wrote
the K3 reset driver. The series that created this directory and these
files is archived at [1].

[1] https://lore.kernel.org/spacemit/20260120-k3-reset-v3-0-effe87f4bdbe@riscstar.com/

Signed-off-by: Guodong Xu <docular.xu@gmail.com>
---
I contributed this driver as Guodong Xu <guodong@riscstar.com>;
docular.xu@gmail.com is my current address. A matching .mailmap update
has been submitted at
https://lore.kernel.org/all/20260601-b4-mailmap-guodong-xu-v1-1-ee9eff1e57ba@gmail.com/
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9ec290e38b44a..c9d87244c1715 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25119,6 +25119,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
 F:	drivers/i2c/busses/i2c-k1.c
 
+SPACEMIT RESET CONTROLLER DRIVER
+M:	Guodong Xu <docular.xu@gmail.com>
+L:	linux-riscv@lists.infradead.org
+S:	Maintained
+F:	drivers/reset/spacemit/
+F:	include/dt-bindings/reset/spacemit,k3-resets.h
+
 SPANISH DOCUMENTATION
 M:	Carlos Bilbao <carlos.bilbao@kernel.org>
 R:	Avadhut Naik <avadhut.naik@amd.com>

---
base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
change-id: 20260601-b4-spacemit-reset-maintainers-4b5a91599585

Best regards,
--  
Guodong Xu <docular.xu@gmail.com>

Re: [PATCH] MAINTAINERS: add entry for SpacemiT reset controller driver

Posted by Yixun Lan 5 days, 21 hours ago

Hi Guodong,

I appreciate someone help on this, only few comments.

On 21:35 Mon 01 Jun     , Guodong Xu wrote:
> The SpacemiT reset controller driver under drivers/reset/spacemit/
> (common code plus the K1 and K3 SoC instances) and its reset-ID header
> have no dedicated MAINTAINERS entry; today they fall only under the
> broad drivers/reset/ entry of the reset subsystem and the N:/K:
> catch-all of the RISC-V SpacemiT SoC umbrella.
> 
It make sense to just fall back to SpacemiT SoC without MAITAINERS
entry, the whole point of adding a didicated entry means someone
willing to put effort in future maintenance, to help review/refactor/fix
you can emphasis on this, and I just want to make sure we algined on
this..

> Add a dedicated entry and list myself as maintainer. I introduced the
> drivers/reset/spacemit/ subdirectory, moved and refactored the existing
> K1 reset support (originally written by Alex Elder) into it, and wrote
> the K3 reset driver. The series that created this directory and these
> files is archived at [1].
> 
This paragraph provide addtional information of the history (which already 
done), I'd personally prefer not puting them into commit message, but put
them below "---" as background introduction if you still want..

> [1] https://lore.kernel.org/spacemit/20260120-k3-reset-v3-0-effe87f4bdbe@riscstar.com/
for the convention, suggest to use more formal format like 
Link: https://.. [1]

> 
also no blank line above

> Signed-off-by: Guodong Xu <docular.xu@gmail.com>
> ---
> I contributed this driver as Guodong Xu <guodong@riscstar.com>;
> docular.xu@gmail.com is my current address. A matching .mailmap update
> has been submitted at
> https://lore.kernel.org/all/20260601-b4-mailmap-guodong-xu-v1-1-ee9eff1e57ba@gmail.com/
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9ec290e38b44a..c9d87244c1715 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25119,6 +25119,13 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
>  F:	drivers/i2c/busses/i2c-k1.c
>  
> +SPACEMIT RESET CONTROLLER DRIVER
> +M:	Guodong Xu <docular.xu@gmail.com>
> +L:	linux-riscv@lists.infradead.org
and I'd still sugest to add spacemit mailing list explicitly

> +S:	Maintained
> +F:	drivers/reset/spacemit/
> +F:	include/dt-bindings/reset/spacemit,k3-resets.h
> +
>  SPANISH DOCUMENTATION
>  M:	Carlos Bilbao <carlos.bilbao@kernel.org>
>  R:	Avadhut Naik <avadhut.naik@amd.com>
> 
> ---
> base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
> change-id: 20260601-b4-spacemit-reset-maintainers-4b5a91599585
> 
> Best regards,
> --  
> Guodong Xu <docular.xu@gmail.com>
> 
> 

-- 
Yixun Lan (dlan)

Re: [PATCH] MAINTAINERS: add entry for SpacemiT reset controller driver

Posted by Guodong Xu 5 days, 5 hours ago

Hi, Yixun

Thanks for the review.

> entry, the whole point of adding a didicated entry means someone
> willing to put effort in future maintenance, to help review/refactor/fix
> you can emphasis on this, and I just want to make sure we algined on

Right, that's the part I should have made explicit. I do plan to keep
maintaining drivers/reset/spacemit/, K1 and K3 now, K5 and K7 as they
land. I'll keep up with review and fixes, and reword the commit message
to say that.

> done), I'd personally prefer not puting them into commit message, but put
> them below "---" as background introduction if you still want..

Sure, will move that below '---'.

>
> > [1] https://lore.kernel.org/spacemit/20260120-k3-reset-v3-0-effe87f4bdbe@riscstar.com/
> for the convention, suggest to use more formal format like
> Link: https://.. [1]
>
> >
> also no blank line above
>

Agree, will do.

> and I'd still sugest to add spacemit mailing list explicitly

I will add that line:
L: spacemit@lists.linux.dev

I'll send v2 with these.

Thank you.
Guodong Xu

>
> --
> Yixun Lan (dlan)

Re: [PATCH] MAINTAINERS: add entry for SpacemiT reset controller driver

Posted by Alex Elder 6 days, 13 hours ago

On 6/1/26 8:35 PM, Guodong Xu wrote:
> The SpacemiT reset controller driver under drivers/reset/spacemit/
> (common code plus the K1 and K3 SoC instances) and its reset-ID header
> have no dedicated MAINTAINERS entry; today they fall only under the
> broad drivers/reset/ entry of the reset subsystem and the N:/K:
> catch-all of the RISC-V SpacemiT SoC umbrella.
> 
> Add a dedicated entry and list myself as maintainer. I introduced the
> drivers/reset/spacemit/ subdirectory, moved and refactored the existing
> K1 reset support (originally written by Alex Elder) into it, and wrote
> the K3 reset driver. The series that created this directory and these
> files is archived at [1].
> 
> [1] https://lore.kernel.org/spacemit/20260120-k3-reset-v3-0-effe87f4bdbe@riscstar.com/
> 
> Signed-off-by: Guodong Xu <docular.xu@gmail.com>

Looks good to me Guodong.

Acked-by: Alex Elder <elder@riscstar.com>

> ---
> I contributed this driver as Guodong Xu <guodong@riscstar.com>;
> docular.xu@gmail.com is my current address. A matching .mailmap update
> has been submitted at
> https://lore.kernel.org/all/20260601-b4-mailmap-guodong-xu-v1-1-ee9eff1e57ba@gmail.com/
> ---
>   MAINTAINERS | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9ec290e38b44a..c9d87244c1715 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25119,6 +25119,13 @@ S:	Maintained
>   F:	Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
>   F:	drivers/i2c/busses/i2c-k1.c
>   
> +SPACEMIT RESET CONTROLLER DRIVER
> +M:	Guodong Xu <docular.xu@gmail.com>
> +L:	linux-riscv@lists.infradead.org
> +S:	Maintained
> +F:	drivers/reset/spacemit/
> +F:	include/dt-bindings/reset/spacemit,k3-resets.h
> +
>   SPANISH DOCUMENTATION
>   M:	Carlos Bilbao <carlos.bilbao@kernel.org>
>   R:	Avadhut Naik <avadhut.naik@amd.com>
> 
> ---
> base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
> change-id: 20260601-b4-spacemit-reset-maintainers-4b5a91599585
> 
> Best regards,
> --
> Guodong Xu <docular.xu@gmail.com>
>