[PATCH] staging: rtl8723bs: remove redundant parentheses

Ben O'Bryan posted 1 patch 1 week, 1 day ago
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] staging: rtl8723bs: remove redundant parentheses
Posted by Ben O'Bryan 1 week, 1 day ago
Remove redundant parentheses around type checks
and align conditional lines to improve readability

Signed-off-by: Ben O'Bryan <obryanbw@gmail.com>
---

This is my first patch to the kernel so please let me know if
I've done anything wrong.

This patch is mostly for me to verify my environment. Assuming
everything goes smoothly, I hope to continue to contribute
more formatting patches as I get more comfortable contributing.

 drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 444966c0de7f..cc38c0c950bb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2476,9 +2476,9 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
 
 			type = GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET);
 
-			if ((type == WIFI_PROBEREQ) ||
-				(type == WIFI_DATA_NULL) ||
-				(type == WIFI_QOS_DATA_NULL)) {
+			if (type == WIFI_PROBEREQ ||
+			    type == WIFI_DATA_NULL ||
+			    type == WIFI_QOS_DATA_NULL) {
 				list_del_init(&pxmitbuf->list);
 				break;
 			}
-- 
2.52.0
Re: [PATCH] staging: rtl8723bs: remove redundant parentheses
Posted by Dan Carpenter 6 days, 20 hours ago
On Sat, May 30, 2026 at 07:41:03PM -0500, Ben O'Bryan wrote:
> Remove redundant parentheses around type checks
> and align conditional lines to improve readability
> 
> Signed-off-by: Ben O'Bryan <obryanbw@gmail.com>
> ---
> 
> This is my first patch to the kernel so please let me know if
> I've done anything wrong.
> 
> This patch is mostly for me to verify my environment. Assuming
> everything goes smoothly, I hope to continue to contribute
> more formatting patches as I get more comfortable contributing.
> 

We don't mind the extra parentheses in staging so we disabled
that checkpatch warning.

regards,
dan carpenter