[PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep

Rosen Penev posted 1 patch 1 week, 1 day ago
drivers/net/ethernet/freescale/fec_mpc52xx.c | 1 +
1 file changed, 1 insertion(+)
[PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
Posted by Rosen Penev 1 week, 1 day ago
Add the missing @may_sleep parameter description to the
mpc52xx_fec_stop kernel-doc comment.

Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/freescale/fec_mpc52xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c
index a770e7edb1dc..4f555bc13ddf 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c
@@ -692,6 +692,7 @@ static void mpc52xx_fec_start(struct net_device *dev)
 /**
  * mpc52xx_fec_stop
  * @dev: network device
+ * @may_sleep: whether the caller can sleep (e.g., to wait for tx drain)
  *
  * stop all activity on fec and empty dma buffers
  */
-- 
2.54.0
Re: [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
Posted by Sebastian Andrzej Siewior 1 week ago
On 2026-05-30 17:00:42 [-0700], Rosen Penev wrote:
> Add the missing @may_sleep parameter description to the
> mpc52xx_fec_stop kernel-doc comment.
> 
> Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian
Re: [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
Posted by Andrew Lunn 1 week, 1 day ago
On Sat, May 30, 2026 at 05:00:42PM -0700, Rosen Penev wrote:
> Add the missing @may_sleep parameter description to the
> mpc52xx_fec_stop kernel-doc comment.
> 
> Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew