drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions

Posted by Rosen Penev 1 week, 1 day ago

dcss_scaler_gaussian_filter() was missing @phase0_identity and
dcss_scaler_filter_design() was missing @phase0_identity and
@nn_interpolation in their kernel-doc comments.

Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 32c3f46b21da..e48b3117efb9 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
  * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
  * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
  * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output filter coefficients
  */
 static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
  * @src_length: length of input
  * @dst_length: length of output
  * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
  */
 static void dcss_scaler_filter_design(int src_length, int dst_length,
 				      bool use_5_taps, bool phase0_identity,
--
2.54.0

Re: [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions

Posted by Laurentiu Palcu 6 days ago

Hi,

There was already a fix sent for this:
https://lore.kernel.org/all/20260406180013.2442096-1-yiconghui@gmail.com/

On Sat, May 30, 2026 at 12:59:25PM -0700, Rosen Penev wrote:
> dcss_scaler_gaussian_filter() was missing @phase0_identity and
> dcss_scaler_filter_design() was missing @phase0_identity and
> @nn_interpolation in their kernel-doc comments.
> 
> Assisted-by: Opencode:Big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index 32c3f46b21da..e48b3117efb9 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -166,6 +166,7 @@ static int exp_approx_q(int x)
>   * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
>   * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
>   * @use_5_taps: indicates whether to use 5 taps or 7 taps
> + * @phase0_identity: use identity filter for phase 0
>   * @coef: output filter coefficients
>   */
>  static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> @@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
>   * @src_length: length of input
>   * @dst_length: length of output
>   * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
> + * @phase0_identity: use identity filter for phase 0
>   * @coef: output coefficients
> + * @nn_interpolation: use nearest neighbor interpolation
>   */
>  static void dcss_scaler_filter_design(int src_length, int dst_length,
>  				      bool use_5_taps, bool phase0_identity,
> --
> 2.54.0
> 

-- 
Thanks,
Laurentiu