scsi: ufs: Remove unnecessary return in void vops wrappers

[PATCH] scsi: ufs: Remove unnecessary return in void vops wrappers

Posted by Chanwoo Lee 1 week, 3 days ago

ufshcd_vops_exit(), ufshcd_vops_setup_task_mgmt(), and
ufshcd_vops_hibern8_notify() use 'return hba->vops->xxx()'
while other void vops wrappers call without return.
Remove the unnecessary return keywords for consistency.

Signed-off-by: Chanwoo Lee <cw9316.lee@samsung.com>
---
 drivers/ufs/core/ufshcd-priv.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
index 70f90d97f217..e55c2a02c1f5 100644
--- a/drivers/ufs/core/ufshcd-priv.h
+++ b/drivers/ufs/core/ufshcd-priv.h
@@ -132,7 +132,7 @@ static inline const char *ufshcd_get_var_name(struct ufs_hba *hba)
 static inline void ufshcd_vops_exit(struct ufs_hba *hba)
 {
 	if (hba->vops && hba->vops->exit)
-		return hba->vops->exit(hba);
+		hba->vops->exit(hba);
 }
 
 static inline u32 ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba)
@@ -211,7 +211,7 @@ static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba *hba,
 					int tag, u8 tm_function)
 {
 	if (hba->vops && hba->vops->setup_task_mgmt)
-		return hba->vops->setup_task_mgmt(hba, tag, tm_function);
+		hba->vops->setup_task_mgmt(hba, tag, tm_function);
 }
 
 static inline void ufshcd_vops_hibern8_notify(struct ufs_hba *hba,
@@ -219,7 +219,7 @@ static inline void ufshcd_vops_hibern8_notify(struct ufs_hba *hba,
 					enum ufs_notify_change_status status)
 {
 	if (hba->vops && hba->vops->hibern8_notify)
-		return hba->vops->hibern8_notify(hba, cmd, status);
+		hba->vops->hibern8_notify(hba, cmd, status);
 }
 
 static inline int ufshcd_vops_apply_dev_quirks(struct ufs_hba *hba)
-- 
2.43.0

Re: [PATCH] scsi: ufs: Remove unnecessary return in void vops wrappers

Posted by Martin K. Petersen 6 days, 10 hours ago

Chanwoo,

> ufshcd_vops_exit(), ufshcd_vops_setup_task_mgmt(), and
> ufshcd_vops_hibern8_notify() use 'return hba->vops->xxx()' while other
> void vops wrappers call without return. Remove the unnecessary return
> keywords for consistency.

Applied to 7.2/scsi-staging, thanks!

-- 
Martin K. Petersen

Re: [PATCH] scsi: ufs: Remove unnecessary return in void vops wrappers

Posted by Bart Van Assche 1 week, 2 days ago

On 5/28/26 11:15 PM, Chanwoo Lee wrote:
> ufshcd_vops_exit(), ufshcd_vops_setup_task_mgmt(), and
> ufshcd_vops_hibern8_notify() use 'return hba->vops->xxx()'
> while other void vops wrappers call without return.
> Remove the unnecessary return keywords for consistency.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH] scsi: ufs: Remove unnecessary return in void vops wrappers

Posted by Peter Wang (王信友) 1 week, 3 days ago

On Fri, 2026-05-29 at 15:15 +0900, Chanwoo Lee wrote:
> ufshcd_vops_exit(), ufshcd_vops_setup_task_mgmt(), and
> ufshcd_vops_hibern8_notify() use 'return hba->vops->xxx()'
> while other void vops wrappers call without return.
> Remove the unnecessary return keywords for consistency.
> 
> Signed-off-by: Chanwoo Lee <cw9316.lee@samsung.com>

Reviewed-by: Peter Wang <peter.wang@mediatek.com>