pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc

[PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc

Posted by Rosen Penev 1 week, 3 days ago

The kernel-doc parser cannot parse 'struct __packed mtk_mfg_opp_entry {'.
Move __packed to the closing brace, which is the more common kernel style.

Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
index 3ce6fb74dd53..53bdab66cf15 100644
--- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
+++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
@@ -236,14 +236,14 @@ struct __packed mtk_mfg_ipi_sleep_msg {
  *
  * This struct is part of the ABI with the EB firmware. Do not change it.
  */
-struct __packed mtk_mfg_opp_entry {
+struct mtk_mfg_opp_entry {
 	__le32 freq_khz;
 	__le32 voltage_core;
 	__le32 voltage_sram;
 	__le32 posdiv;
 	__le32 voltage_margin;
 	__le32 power_mw;
-};
+} __packed;

 struct mtk_mfg_mbox {
 	struct mbox_client cl;
--
2.54.0

Re: [PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc

Posted by Ulf Hansson 5 days, 3 hours ago

On Thu, May 28, 2026 at 10:25 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> The kernel-doc parser cannot parse 'struct __packed mtk_mfg_opp_entry {'.
> Move __packed to the closing brace, which is the more common kernel style.
>
> Assisted-by: Opencode:Big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> index 3ce6fb74dd53..53bdab66cf15 100644
> --- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> +++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> @@ -236,14 +236,14 @@ struct __packed mtk_mfg_ipi_sleep_msg {
>   *
>   * This struct is part of the ABI with the EB firmware. Do not change it.
>   */
> -struct __packed mtk_mfg_opp_entry {
> +struct mtk_mfg_opp_entry {
>         __le32 freq_khz;
>         __le32 voltage_core;
>         __le32 voltage_sram;
>         __le32 posdiv;
>         __le32 voltage_margin;
>         __le32 power_mw;
> -};
> +} __packed;
>
>  struct mtk_mfg_mbox {
>         struct mbox_client cl;
> --
> 2.54.0
>