tpm: tpm_tis: Fix probe of some older TPMs

[PATCH v3 0/2] tpm: tpm_tis: Fix probe of some older TPMs

Posted by Jim Broadus 1 week, 5 days ago

Changes v3:
- Renamed the series from "Add optional delay after relinquish" to
  "Fix probe of some older TPMs"
- Addressed review comment, saving entire did_vid in priv structure.
- Use did_vid value to identify problem TPM and apply quirk.
Changes v2:
- Move delay from tpm_tis_relinquish_locality to
  __tpm_tis_relinquish_locality.

Link to v2: https://lore.kernel.org/all/20260519154530.6386-1-jbroadus@gmail.com/

Jim Broadus (2):
  tpm: tpm_tis: store entire did_vid
  tpm: tpm_tis: Add settle time for some TPMs

 drivers/char/tpm/tpm_tis_core.c | 28 ++++++++++++++++++++--------
 drivers/char/tpm/tpm_tis_core.h |  3 ++-
 2 files changed, 22 insertions(+), 9 deletions(-)

-- 
2.54.0

Re: [PATCH v3 0/2] tpm: tpm_tis: Fix probe of some older TPMs

Posted by Jarkko Sakkinen 6 days, 22 hours ago

On Tue, May 26, 2026 at 04:22:42PM -0700, Jim Broadus wrote:
> Changes v3:
> - Renamed the series from "Add optional delay after relinquish" to
>   "Fix probe of some older TPMs"
> - Addressed review comment, saving entire did_vid in priv structure.
> - Use did_vid value to identify problem TPM and apply quirk.
> Changes v2:
> - Move delay from tpm_tis_relinquish_locality to
>   __tpm_tis_relinquish_locality.
> 
> Link to v2: https://lore.kernel.org/all/20260519154530.6386-1-jbroadus@gmail.com/
> 
> Jim Broadus (2):
>   tpm: tpm_tis: store entire did_vid
>   tpm: tpm_tis: Add settle time for some TPMs
> 
>  drivers/char/tpm/tpm_tis_core.c | 28 ++++++++++++++++++++--------
>  drivers/char/tpm/tpm_tis_core.h |  3 ++-
>  2 files changed, 22 insertions(+), 9 deletions(-)
> 
> -- 
> 2.54.0
> 

Applied.  Thank you!

BR, Jarkko

Re: [PATCH v3 0/2] tpm: tpm_tis: Fix probe of some older TPMs

Posted by Jarkko Sakkinen 1 week, 2 days ago

On Tue, May 26, 2026 at 04:22:42PM -0700, Jim Broadus wrote:
> Changes v3:
> - Renamed the series from "Add optional delay after relinquish" to
>   "Fix probe of some older TPMs"
> - Addressed review comment, saving entire did_vid in priv structure.
> - Use did_vid value to identify problem TPM and apply quirk.
> Changes v2:
> - Move delay from tpm_tis_relinquish_locality to
>   __tpm_tis_relinquish_locality.
> 
> Link to v2: https://lore.kernel.org/all/20260519154530.6386-1-jbroadus@gmail.com/
> 
> Jim Broadus (2):
>   tpm: tpm_tis: store entire did_vid
>   tpm: tpm_tis: Add settle time for some TPMs
> 
>  drivers/char/tpm/tpm_tis_core.c | 28 ++++++++++++++++++++--------
>  drivers/char/tpm/tpm_tis_core.h |  3 ++-
>  2 files changed, 22 insertions(+), 9 deletions(-)
> 
> -- 
> 2.54.0
> 

I think this now much better structured, thank you. I'll add this thread
to my TODO folder and try it out before any further feedback.

BR, Jarkko