[PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE

Arnd Bergmann posted 1 patch 1 week, 6 days ago
drivers/leds/rgb/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
Posted by Arnd Bergmann 1 week, 6 days ago
From: Arnd Bergmann <arnd@arndb.de>

Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:

WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
  Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n]
  Selected by [y]:
  - LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]

Address this by adding the same dependency here as well.

Fixes: 3daf2c4ef82b ("leds: Add support for TI LP5860 LED driver chip")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Another option would be to change the 'select LEDS_LP5860_CORE' to
a 'depends on'.
---
 drivers/leds/rgb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 9a4ba6531cf8..b582ba2363af 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -56,6 +56,7 @@ config LEDS_LP5860_CORE
 config LEDS_LP5860_SPI
 	tristate "LED Support for TI LP5860 SPI LED driver chip"
 	depends on SPI
+	depends on OF
 	select LEDS_LP5860_CORE
 	help
 	  If you say yes here you get support for the Texas Instruments
-- 
2.39.5
Re: (subset) [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
Posted by Lee Jones 4 days, 4 hours ago
On Tue, 26 May 2026 12:37:32 +0200, Arnd Bergmann wrote:
> Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:
> 
> WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
>   Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n]
>   Selected by [y]:
>   - LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]
> 
> [...]

Applied, thanks!

[1/1] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
      commit: a2263676302a4eec40af93b3829f1d3d5aade93c

--
Lee Jones [李琼斯]