cpufreq/amd-pstate: drop stale @epp_cached kdoc

[PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc

Posted by Zhan Xusheng 1 week, 6 days ago

Commit 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP") removed
the epp_cached field from struct amd_cpudata in favour of always
reading from cppc_req_cached, but the kdoc above the struct still
documents @epp_cached.

Drop the now-stale @epp_cached entry.

Fixes: 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP")
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
 drivers/cpufreq/amd-pstate.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
index e4722e54387b..23e8baa05849 100644
--- a/drivers/cpufreq/amd-pstate.h
+++ b/drivers/cpufreq/amd-pstate.h
@@ -84,7 +84,6 @@ struct amd_aperf_mperf {
  * @hw_prefcore: check whether HW supports preferred core featue.
  * 		  Only when hw_prefcore and early prefcore param are true,
  * 		  AMD P-State driver supports preferred core featue.
- * @epp_cached: Cached CPPC energy-performance preference value
  * @policy: Cpufreq policy value
  * @suspended: If CPU core if offlined
  * @epp_default_ac: Default EPP value for AC power source
-- 
2.43.0

Re: [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc

Posted by Mario Limonciello 1 week, 6 days ago


On 5/26/26 03:21, Zhan Xusheng wrote:
> Commit 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP") removed
> the epp_cached field from struct amd_cpudata in favour of always
> reading from cppc_req_cached, but the kdoc above the struct still
> documents @epp_cached.
> 
> Drop the now-stale @epp_cached entry.
> 
> Fixes: 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP")
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Also added to my tree.

>   drivers/cpufreq/amd-pstate.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index e4722e54387b..23e8baa05849 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -84,7 +84,6 @@ struct amd_aperf_mperf {
>    * @hw_prefcore: check whether HW supports preferred core featue.
>    * 		  Only when hw_prefcore and early prefcore param are true,
>    * 		  AMD P-State driver supports preferred core featue.
> - * @epp_cached: Cached CPPC energy-performance preference value
>    * @policy: Cpufreq policy value
>    * @suspended: If CPU core if offlined
>    * @epp_default_ac: Default EPP value for AC power source