Support for the main PMIC5 Gen3 ADC driver has been merged now.
In order to complete adding support for the Gen3 ADC_TM auxiliary
driver, some more changes are needed in the main driver, mainly to
improve its shared interrupt's handling mechanism.
Patch 1 simplifies the interrupt handling in the main ADC driver
by declaring the interrupt as a shared one and dropping the logic
used to call the ADC_TM notifier for handling ADC_TM interrupts on
the first SDAM whose interrupt is shared.
Patch 2 adds the auxiliary thermal driver which supports the ADC_TM
functionality of ADC5 Gen3.
Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
---
Changes in v2:
- Updated IRQ request API to request threaded interrupt in main ADC driver, keeping
primary handler NULL and using existing handler as threaded handler, to avoid
kernel warning for using IRQF_ONESHOT with non-threaded interrupts.
- Link to v1: https://patch.msgid.link/20260515-gen3_adc_tm-v1-0-39ba29f9b4ab@oss.qualcomm.com
Link to previous ADC5 Gen3 patch series:
V10: https://lore.kernel.org/all/20260130115421.2197892-1-jishnu.prakash@oss.qualcomm.com/
Patches 1-3 of the above series have been merged now. Patch 4 received some
later comments which are addressed in this series.
Patch 2 of this present series is derived from patch 4 of the above series,
with some changes.
Changes since V10:
- Added patch 1 of this series to make the SDAM0 IRQ a shared IRQ and
remove ADC_TM notifier, as suggested by Daniel.
- Made following changes to address Daniel's comments on patch 4 in
previous series:
- Added IRQ request call for SDAM0 IRQ, marking it as a shared IRQ.
- Split interrupt handler into main and threaded IRQ functions.
- Removed workqueue used in IRQ handler and its cleanup, instead use threaded
part of handler for same functionality.
- Removed callback function exposed to main ADC driver for TM IRQ handling on first SDAM.
- Removed workaround to capture temperature causing threshold violation inside interrupt
handler and then return this on next get_temp() call.
- Removed all error prints in interrupt handler and updated return value to IRQ_NONE
in case of errors.
- Removed explicit check to disable ADC_TM channel in case of (INT_MAX/-INT_MAX)
high/low thresholds being set in .set_trips callback.
- Also addressed Jonathan's comments on V10 patch 4 related to header file inclusion and for()
loop iterator initialization.
- Dropped Reviewed-by tag from Jonathan on V10 patch 4 due to significant changes made now.
- Added a status clearing register write in adc_tm5_gen3_disable_channel(), missed earlier.
- Moved cleanup action to disable ADC_TM channels in driver probe to just before IRQ requests,
for proper utilization.
---
Jishnu Prakash (2):
iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver
thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring
drivers/iio/adc/qcom-spmi-adc5-gen3.c | 66 ++--
drivers/thermal/qcom/Kconfig | 9 +
drivers/thermal/qcom/Makefile | 1 +
drivers/thermal/qcom/qcom-spmi-adc-tm5-gen3.c | 437 ++++++++++++++++++++++++++
include/linux/iio/adc/qcom-adc5-gen3-common.h | 2 -
5 files changed, 466 insertions(+), 49 deletions(-)
---
base-commit: e7ae89a0c97ce2b68b0983cd01eda67cf373517d
change-id: 20260514-gen3_adc_tm-410dcb98be62
Best regards,
--
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>