[PATCH v2] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16

Nishanth Sampath Kumar posted 1 patch 5 days, 2 hours ago
There is a newer version of this series
drivers/base/regmap/regmap-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
Posted by Nishanth Sampath Kumar 5 days, 2 hours ago
i2c_smbus_write_word_data() expects a plain u16, but cpu_to_le16()
returns __le16 (a sparse-restricted endian type), causing:

  drivers/base/regmap/regmap-i2c.c:340: sparse: incorrect type in
  argument 3 (different base types)
    expected unsigned short [usertype] value
    got restricted __le16 [usertype]

SMBus already defines byte ordering internally, so cpu_to_le16() is
wrong here. Replace it with a plain (u16) cast.

Fixes: bad4bd28abf4 ("regmap-i2c: add SMBus byte/word reg16 bus for adapters lacking I2C_FUNC_I2C")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605161621.mY5zFh4D-lkp@intel.com/
Signed-off-by: Nishanth Sampath Kumar <nissampa@cisco.com>
---
 drivers/base/regmap/regmap-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap-i2c.c b/drivers/base/regmap/regmap-i2c.c
index 31e30dfced19..51a04961faf7 100644
--- a/drivers/base/regmap/regmap-i2c.c
+++ b/drivers/base/regmap/regmap-i2c.c
@@ -337,7 +337,7 @@ static int regmap_smbus_word_write_reg16(void *context, const void *data,
 	val = ((u8 *)data)[2];
 
 	return i2c_smbus_write_word_data(i2c, addr_hi,
-					 cpu_to_le16(((u16)val << 8) | addr_lo));
+					 ((u16)val << 8) | addr_lo);
 }
 
 static const struct regmap_bus regmap_smbus_byte_word_reg16 = {
-- 
2.25.1
Re: [PATCH v2] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
Posted by Mark Brown 4 days, 12 hours ago
On Tue, 19 May 2026 15:05:57 -0700, Nishanth Sampath Kumar wrote:
> regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-7.2

Thanks!

[1/1] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
      https://git.kernel.org/broonie/regmap/c/19a5211cda12

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH v2] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
Posted by Mark Brown 4 days, 14 hours ago
On Tue, May 19, 2026 at 03:05:57PM -0700, Nishanth Sampath Kumar wrote:
> i2c_smbus_write_word_data() expects a plain u16, but cpu_to_le16()
> returns __le16 (a sparse-restricted endian type), causing:

Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.