[v2] perf: Fix missing branch counter information in script and annotate

[RESEND PATCH 0/2 v2] perf: Fix missing branch counter information in script and annotate

Posted by Thomas Falcon 5 days, 6 hours ago

This series fixes two issues related to branch counter (br_cntr)
display in perf.

The first patch fixes a missing '+' indicator in 'perf script' output.
The '+' suffix is used to signal that event occurrences may have been
lost due to branch counter overflow.

The second patch fixes a regression in 'perf annotate' TUI mode where
the Branch Count column was never displayed. The check for whether to
enable branch counter display was performed before events were processed
and the counter data was populated, so the condition was never satisfied.
Moving the check to after event processing resolves this.

v2: Added a cover letter and expanded commit message for patch 1/2.
    Patch 2/2 was missing some conditional checks to enable branch counter
    display, which have been added back.
    

Dapeng Mi (1):
  perf script: Fix missing '+' indicator when branch counter reaches
    upper limit

Thomas Falcon (1):
  perf annotate: Fix missing branch counter column in TUI mode

 tools/perf/builtin-annotate.c | 9 +++++----
 tools/perf/builtin-script.c   | 8 ++++++--
 2 files changed, 11 insertions(+), 6 deletions(-)

-- 
2.43.0

Re: [RESEND PATCH 0/2 v2] perf: Fix missing branch counter information in script and annotate

Posted by Ian Rogers 5 days, 5 hours ago

On Tue, May 19, 2026 at 10:50 AM Thomas Falcon <thomas.falcon@intel.com> wrote:
>
> This series fixes two issues related to branch counter (br_cntr)
> display in perf.
>
> The first patch fixes a missing '+' indicator in 'perf script' output.
> The '+' suffix is used to signal that event occurrences may have been
> lost due to branch counter overflow.
>
> The second patch fixes a regression in 'perf annotate' TUI mode where
> the Branch Count column was never displayed. The check for whether to
> enable branch counter display was performed before events were processed
> and the counter data was populated, so the condition was never satisfied.
> Moving the check to after event processing resolves this.
>
> v2: Added a cover letter and expanded commit message for patch 1/2.
>     Patch 2/2 was missing some conditional checks to enable branch counter
>     display, which have been added back.
>
>
> Dapeng Mi (1):
>   perf script: Fix missing '+' indicator when branch counter reaches
>     upper limit
>
> Thomas Falcon (1):
>   perf annotate: Fix missing branch counter column in TUI mode

For the series:
Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

>  tools/perf/builtin-annotate.c | 9 +++++----
>  tools/perf/builtin-script.c   | 8 ++++++--
>  2 files changed, 11 insertions(+), 6 deletions(-)
>
> --
> 2.43.0
>