ALSA: oss: Use flexible allocation for PCM plugins

[PATCH] ALSA: oss: Use flexible allocation for PCM plugins

Posted by Rosen Penev 6 days, 3 hours ago

Allocate PCM plugin objects with kzalloc_flex() for the trailing
extra data area instead of open-coding the size calculation.

This keeps the allocation tied to the existing flexible array member
without changing the plugin lifetime.

Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 sound/core/oss/pcm_plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/oss/pcm_plugin.c b/sound/core/oss/pcm_plugin.c
index 14b4a390a219..5f4d6945a7df 100644
--- a/sound/core/oss/pcm_plugin.c
+++ b/sound/core/oss/pcm_plugin.c
@@ -146,7 +146,7 @@ int snd_pcm_plugin_build(struct snd_pcm_substream *plug,
 		return -ENXIO;
 	if (snd_BUG_ON(!src_format || !dst_format))
 		return -ENXIO;
-	plugin = kzalloc(sizeof(*plugin) + extra, GFP_KERNEL);
+	plugin = kzalloc_flex(*plugin, extra_data, extra);
 	if (plugin == NULL)
 		return -ENOMEM;
 	plugin->name = name;
-- 
2.54.0

Re: [PATCH] ALSA: oss: Use flexible allocation for PCM plugins

Posted by Takashi Iwai 5 days, 21 hours ago

On Tue, 19 May 2026 02:46:47 +0200,
Rosen Penev wrote:
> 
> Allocate PCM plugin objects with kzalloc_flex() for the trailing
> extra data area instead of open-coding the size calculation.
> 
> This keeps the allocation tied to the existing flexible array member
> without changing the plugin lifetime.
> 
> Assisted-by: Codex:GPT-5.5
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied to for-next branch.  Thanks.


Takashi