efi: sysfb_efi: Extend quirk to cover IdeaPad Duet 3 10IGL5-LTE

[PATCH] efi: sysfb_efi: Extend quirk to cover IdeaPad Duet 3 10IGL5-LTE

Posted by Marius Hoch 1 week ago

The LTE enabled version of the IdeaPad Duet 3 10IGL5 needs the
same quirk as the non-LTE version. As these are the only two
IdeaPad Duet 3 10IGL5 versions, we can safely use non exact matching.

Tested on a IdeaPad Duet 3 10IGL5-LTE.

Signed-off-by: Marius Hoch <mail@mariushoch.de>
---
 drivers/firmware/efi/sysfb_efi.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
index 4c3986ddcd54..685283bb7327 100644
--- a/drivers/firmware/efi/sysfb_efi.c
+++ b/drivers/firmware/efi/sysfb_efi.c
@@ -311,11 +311,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
 		.callback = efifb_swap_width_height,
 	},
 	{
-		/* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
+		/*
+		 * Lenovo IdeaPad Duet 3 10IGL5 and 10IGL5-LTE with
+		 * 1200x1920 portrait screen
+		 */
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
-					"IdeaPad Duet 3 10IGL5"),
+			/* Non exact match to also match the LTE version */
+			DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
 		},
 		.callback = efifb_swap_width_height,
 	},
-- 
2.54.0

Re: [PATCH] efi: sysfb_efi: Extend quirk to cover IdeaPad Duet 3 10IGL5-LTE

Posted by Ard Biesheuvel 5 days, 14 hours ago

On Sun, 17 May 2026, at 21:23, Marius Hoch wrote:
> The LTE enabled version of the IdeaPad Duet 3 10IGL5 needs the
> same quirk as the non-LTE version. As these are the only two
> IdeaPad Duet 3 10IGL5 versions, we can safely use non exact matching.
>
> Tested on a IdeaPad Duet 3 10IGL5-LTE.
>
> Signed-off-by: Marius Hoch <mail@mariushoch.de>
> ---
>  drivers/firmware/efi/sysfb_efi.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>

Thanks, I'll queue this up (unless anyone has objections?)

> diff --git a/drivers/firmware/efi/sysfb_efi.c 
> b/drivers/firmware/efi/sysfb_efi.c
> index 4c3986ddcd54..685283bb7327 100644
> --- a/drivers/firmware/efi/sysfb_efi.c
> +++ b/drivers/firmware/efi/sysfb_efi.c
> @@ -311,11 +311,14 @@ static const struct dmi_system_id 
> efifb_dmi_swap_width_height[] __initconst = {
>  		.callback = efifb_swap_width_height,
>  	},
>  	{
> -		/* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
> +		/*
> +		 * Lenovo IdeaPad Duet 3 10IGL5 and 10IGL5-LTE with
> +		 * 1200x1920 portrait screen
> +		 */
>  		.matches = {
>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
> -					"IdeaPad Duet 3 10IGL5"),
> +			/* Non exact match to also match the LTE version */
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
>  		},
>  		.callback = efifb_swap_width_height,
>  	},
> -- 
> 2.54.0